Page MenuHomePhabricator

Set contract flag when setting unsafe algebra flag
AbandonedPublic

Authored by yuyichao on Oct 25 2017, 10:05 PM.

Details

Reviewers
spatel
anemet
Summary

I assume this was a oversight in D31164

Diff Detail

Event Timeline

yuyichao created this revision.Oct 25 2017, 10:05 PM
spatel edited edge metadata.Oct 26 2017, 6:28 AM

This is correct, but I've proposed to remove UnsafeAlgebra in D39304. Do you need this right away, or can we wait for that change to proceed? Another possibility if we need this fixed immediately is to split up my patch so that the 'trans' bit is a follow-up.

yuyichao abandoned this revision.Oct 26 2017, 7:23 AM

Do you need this right away, or can we wait for that change to proceed?

Nah, I just notice this by accident when trying to workaround https://bugs.llvm.org/show_bug.cgi?id=35091 I noticed that you fix it too so I will just close this.