This is an archive of the discontinued LLVM Phabricator instance.

CodeGen: Fix invalid bitcast in partial initialization of automatic arrary variable
ClosedPublic

Authored by yaxunl on Oct 23 2017, 8:59 AM.

Reviewers

Commits

LGTM.

This revision is now accepted and ready to land.Oct 23 2017, 9:55 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

cfe/

trunk/

lib/

CodeGen/

2 lines

test/

CodeGenOpenCL/

8 lines

Show First 20 Lines • Show All 1,260 Lines • ▼ Show 20 Lines	void CodeGenFunction::EmitAutoVarInit(const AutoVarEmission &emission) {
// If this is a simple aggregate initialization, we can optimize it		// If this is a simple aggregate initialization, we can optimize it
// in various ways.		// in various ways.
bool isVolatile = type.isVolatileQualified();		bool isVolatile = type.isVolatileQualified();

llvm::Value *SizeVal =		llvm::Value *SizeVal =
llvm::ConstantInt::get(IntPtrTy,		llvm::ConstantInt::get(IntPtrTy,
getContext().getTypeSizeInChars(type).getQuantity());		getContext().getTypeSizeInChars(type).getQuantity());

llvm::Type *BP = Int8PtrTy;		llvm::Type *BP = AllocaInt8PtrTy;
if (Loc.getType() != BP)		if (Loc.getType() != BP)
Loc = Builder.CreateBitCast(Loc, BP);		Loc = Builder.CreateBitCast(Loc, BP);

// If the initializer is all or mostly zeros, codegen with memset then do		// If the initializer is all or mostly zeros, codegen with memset then do
// a few stores afterward.		// a few stores afterward.
if (shouldUseMemSetPlusStoresToInitialize(constant,		if (shouldUseMemSetPlusStoresToInitialize(constant,
CGM.getDataLayout().getTypeAllocSize(constant->getType()))) {		CGM.getDataLayout().getTypeAllocSize(constant->getType()))) {
Builder.CreateMemSet(Loc, llvm::ConstantInt::get(Int8Ty, 0), SizeVal,		Builder.CreateMemSet(Loc, llvm::ConstantInt::get(Int8Ty, 0), SizeVal,
▲ Show 20 Lines • Show All 667 Lines • Show Last 20 Lines

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Lines	void func2(void) {
// CL20: call void @func1(i32* %[[r2]])		// CL20: call void @func1(i32* %[[r2]])
func1(&lv1);		func1(&lv1);

// CHECK: store i32 4, i32 addrspace(5)* %lvc		// CHECK: store i32 4, i32 addrspace(5)* %lvc
// CHECK: store i32 4, i32 addrspace(5)* %lv1		// CHECK: store i32 4, i32 addrspace(5)* %lv1
const int lvc = 4;		const int lvc = 4;
lv1 = lvc;		lv1 = lvc;
}		}

		// CHECK-LABEL: define void @func3()
		// CHECK: %a = alloca [16 x [1 x float]], align 4, addrspace(5)
		// CHECK: %[[CAST:.+]] = bitcast [16 x [1 x float]] addrspace(5)* %a to i8 addrspace(5)*
		// CHECK: call void @llvm.memset.p5i8.i64(i8 addrspace(5)* %[[CAST]], i8 0, i64 64, i32 4, i1 false)
		void func3(void) {
		float a[16][1] = {{0.}};
		}