Page MenuHomePhabricator

[Driver] Use ld.lld directly for Fuchsia rather than passing flavor
ClosedPublic

Authored by phosek on Oct 22 2017, 10:47 PM.

Details

Summary

Passing a flavor to LLD requires command line argument, but if these
are being passed through a response file, this will fail because LLD
needs to know which driver to use before processing the response file.
Use ld.lld directly instead to avoid this issue.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Oct 22 2017, 10:47 PM
phosek updated this revision to Diff 119923.Oct 23 2017, 12:44 PM
mcgrathr accepted this revision.Oct 23 2017, 1:13 PM

This seems like how it always should have been, since -fuse-ld=lld sets it to ld.lld, not lld.
Looks to me like the existing MipsLinux and WebAssembly implementations are wrong too and only BareMetal is right.

This revision is now accepted and ready to land.Oct 23 2017, 1:13 PM
This revision was automatically updated to reflect the committed changes.