This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Do not abort if overflow check does not use EQ or NE.
ClosedPublic

Authored by jgalenson on Oct 20 2017, 3:27 PM.

Details

Summary

As suggested by Eli Friedman, instead of aborting if an overflow check uses something other than SETEQ or SETNE, simply do not apply the optimization.

Diff Detail

Repository
rL LLVM

Event Timeline

jgalenson created this revision.Oct 20 2017, 3:27 PM
efriedma accepted this revision.Oct 20 2017, 3:35 PM

LGTM. (I'm pretty sure it's possible to come up with a testcase, but it's not worth the time to figure out what exact legalization sequence would trigger this.)

This revision is now accepted and ready to land.Oct 20 2017, 3:35 PM

Thanks. Could you commit this for me?

jgalenson retitled this revision from Do not abort if overflow check does not use EQ or NE. to [AArch64] Do not abort if overflow check does not use EQ or NE..Nov 9 2017, 9:31 AM
This revision was automatically updated to reflect the committed changes.