Page MenuHomePhabricator

[RISCV 12.5/n] Codegen support for memory operations on global addresses
ClosedPublic

Authored by asb on Oct 19 2017, 12:21 PM.

Details

Summary

Splitting this out from D29934, as requested during review.

This patch adds support for lowering global addresses and tests for load/store on those addresses.

Diff Detail

Repository
rL LLVM

Event Timeline

asb created this revision.Oct 19 2017, 12:21 PM
asb updated this revision to Diff 119608.Oct 19 2017, 12:24 PM

I accidentally ttached an older version of the patch before, which had an unwanted whitespace change.

reames accepted this revision.Oct 20 2017, 4:02 PM

LGTM

lib/Target/RISCV/RISCVMCInstLower.cpp
27 ↗(On Diff #119608)

FYI, the diff here is confusing and part of what made me request you split this. If you'd extracted the helper function as a separate NFC change without review (which would have been fine), the reduced diff would have been a lot more obvious.

This revision is now accepted and ready to land.Oct 20 2017, 4:02 PM
This revision was automatically updated to reflect the committed changes.