STL reviewed my [[nodiscard]] changes and suggested a ton more places. These are the associated test changes in libcxx.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
I think I would prefer if this patch "left an explicit trace" as to the reasons for all the (void) casts. Specifically I think a macro like TEST_IGNORE_DISCARD <expr> might be nice.
@BillyONeal What do you think?
Otherwise this LGTM.