This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Tolerate even more [[nodiscard]] in the STL.
ClosedPublic

Authored by BillyONeal on Oct 18 2017, 10:12 PM.

Details

Summary

STL reviewed my [[nodiscard]] changes and suggested a ton more places. These are the associated test changes in libcxx.

Diff Detail

Event Timeline

BillyONeal created this revision.Oct 18 2017, 10:12 PM
EricWF accepted this revision.Nov 6 2017, 6:28 PM

I think I would prefer if this patch "left an explicit trace" as to the reasons for all the (void) casts. Specifically I think a macro like TEST_IGNORE_DISCARD <expr> might be nice.

@BillyONeal What do you think?

Otherwise this LGTM.

This revision is now accepted and ready to land.Nov 6 2017, 6:28 PM
BillyONeal closed this revision.Nov 14 2017, 11:46 PM