Page MenuHomePhabricator

[XRay][compiler-rt] Always place the CPU record first for every buffer
ClosedPublic

Authored by dberris on Oct 17 2017, 2:59 AM.

Details

Summary

In FDR Mode, when we set up a new buffer for a thread that's just
overflowed, we must place the CPU identifier with the TSC record as the
first record. This is so that we can reconstruct all the function
entry/exit with deltas rooted on a TSC record for the CPU at the
beginning of the buffer.

Without doing this, the tools are rejecting the log for cases when we've
overflown and have different buffers that don't have the CPU and TSC
records as the first entry in the buffers.

Diff Detail

Repository
rL LLVM

Event Timeline

dberris created this revision.Oct 17 2017, 2:59 AM
pelikan accepted this revision.Oct 17 2017, 3:32 AM
This revision is now accepted and ready to land.Oct 17 2017, 3:32 AM
This revision was automatically updated to reflect the committed changes.