This is an archive of the discontinued LLVM Phabricator instance.

[MBP] Scheduled blocks have been removed from worklist
Needs ReviewPublic

Authored by trentxintong on Oct 7 2017, 11:35 PM.

Reviewers

Summary

Scheduled blocks have been removed from worklist in the beginning of the function.

Build Status

Buildable 10964
Build 10964: arc lint + arc unit

Path

Size

lib/

CodeGen/

6 lines

Show First 20 Lines • Show All 1,577 Lines • ▼ Show 20 Lines	MachineBasicBlock *MachineBlockPlacement::selectBestCandidateBlock(
bool IsEHPad = WorkList[0]->isEHPad();		bool IsEHPad = WorkList[0]->isEHPad();

MachineBasicBlock *BestBlock = nullptr;		MachineBasicBlock *BestBlock = nullptr;
BlockFrequency BestFreq;		BlockFrequency BestFreq;
for (MachineBasicBlock *MBB : WorkList) {		for (MachineBasicBlock *MBB : WorkList) {
assert(MBB->isEHPad() == IsEHPad &&		assert(MBB->isEHPad() == IsEHPad &&
"EHPad mismatch between block and work list.");		"EHPad mismatch between block and work list.");

BlockChain &SuccChain = *BlockToChain[MBB];		assert(BlockToChain[MBB]->UnscheduledPredecessors == 0 &&
if (&SuccChain == &Chain)
continue;

assert(SuccChain.UnscheduledPredecessors == 0 &&
"Found CFG-violating block");		"Found CFG-violating block");

BlockFrequency CandidateFreq = MBFI->getBlockFreq(MBB);		BlockFrequency CandidateFreq = MBFI->getBlockFreq(MBB);
DEBUG(dbgs() << " " << getBlockName(MBB) << " -> ";		DEBUG(dbgs() << " " << getBlockName(MBB) << " -> ";
MBFI->printBlockFreq(dbgs(), CandidateFreq) << " (freq)\n");		MBFI->printBlockFreq(dbgs(), CandidateFreq) << " (freq)\n");

// For ehpad, we layout the least probable first as to avoid jumping back		// For ehpad, we layout the least probable first as to avoid jumping back
// from least probable landingpads to more probable ones.		// from least probable landingpads to more probable ones.
▲ Show 20 Lines • Show All 1,304 Lines • Show Last 20 Lines