This is an archive of the discontinued LLVM Phabricator instance.

[MIPS] Don't crash when parsing a subu with an undefined symbol
AbandonedPublic

Authored by arichardson on Sep 29 2017, 4:47 AM.

Reviewers

Summary

This is a patch originally by David Chisnall
(https://github.com/CTSRD-CHERI/llvm/commit/176118426c) with an added test
case

Build Status

Buildable 10678
Build 10678: arc lint + arc unit

PR34391 which I believe is the same issue, https://reviews.llvm.org/D37476 should address this.

Ah I hadn't seen that one. Indeed that is a lot better.

Path

Size

lib/

Target/

Mips/

AsmParser/

3 lines

test/

MC/

Mips/

4 lines

Show First 20 Lines • Show All 5,860 Lines • ▼ Show 20 Lines	MipsAsmParser::parseInvNum(OperandVector &Operands) {
const MCExpr *IdVal;		const MCExpr *IdVal;
// If the first token is '$' we may have register operand.		// If the first token is '$' we may have register operand.
if (Parser.getTok().is(AsmToken::Dollar))		if (Parser.getTok().is(AsmToken::Dollar))
return MatchOperand_NoMatch;		return MatchOperand_NoMatch;
SMLoc S = Parser.getTok().getLoc();		SMLoc S = Parser.getTok().getLoc();
if (getParser().parseExpression(IdVal))		if (getParser().parseExpression(IdVal))
return MatchOperand_ParseFail;		return MatchOperand_ParseFail;
const MCConstantExpr *MCE = dyn_cast<MCConstantExpr>(IdVal);		const MCConstantExpr *MCE = dyn_cast<MCConstantExpr>(IdVal);
assert(MCE && "Unexpected MCExpr type.");		if (!MCE)
		return MatchOperand_ParseFail;
int64_t Val = MCE->getValue();		int64_t Val = MCE->getValue();
SMLoc E = SMLoc::getFromPointer(Parser.getTok().getLoc().getPointer() - 1);		SMLoc E = SMLoc::getFromPointer(Parser.getTok().getLoc().getPointer() - 1);
Operands.push_back(MipsOperand::CreateImm(		Operands.push_back(MipsOperand::CreateImm(
MCConstantExpr::create(0 - Val, getContext()), S, E, *this));		MCConstantExpr::create(0 - Val, getContext()), S, E, *this));
return MatchOperand_Success;		return MatchOperand_Success;
}		}

OperandMatchResultTy		OperandMatchResultTy
▲ Show 20 Lines • Show All 1,906 Lines • Show Last 20 Lines

				# RUN: not llvm-mc -triple=mips64-unknown-freebsd -filetype=obj -mcpu=mips64 \
				# RUN: -target-abi n64 -o - %s 2>&1 \| FileCheck %s
				# CHECK: error: unexpected token in argument list
				subu a, b