This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objcopy] Add test to check that architecture specific values are not used on wrong architecture.
ClosedPublic

Authored by jakehehrlich on Sep 18 2017, 5:54 PM.

Reviewers

jhenderson
phosek

Commits

Summary

This change adds a test that checks the an error is produced when a hexagon specific reserved section index is used but e_machine is not EM_HEXAGON

Oh and it also fixes a blemish that I let slip though the cracks in section-index-unsupported.test (a related test)

LGTM.

This revision is now accepted and ready to land.Sep 19 2017, 1:56 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

test/

tools/

llvm-objcopy/

15 lines

2 lines

				# RUN: yaml2obj %s > %t
				# RUN: not llvm-objcopy %t %t2 2>&1 >/dev/null \| FileCheck %s

				!ELF
				FileHeader:
				Class: ELFCLASS64
				Data: ELFDATA2LSB
				Type: ET_EXEC
				Machine: EM_X86_64
				Symbols:
				Global:
				- Name: test
				Index: SHN_HEXAGON_SCOMMON

				# CHECK: Symbol 'test' has unsupported value greater than or equal to SHN_LORESERVE: 65280

	# RUN: yaml2obj %s > %t			# RUN: yaml2obj %s > %t
	# RUN: not llvm-objcopy %t %t2 2>&1 >/dev/null \| FileCheck %s			# RUN: not llvm-objcopy %t %t2 2>&1 >/dev/null \| FileCheck %s

	!ELF			!ELF
	FileHeader:			FileHeader:
	Class: ELFCLASS64			Class: ELFCLASS64
	Data: ELFDATA2LSB			Data: ELFDATA2LSB
	Type: ET_EXEC			Type: ET_EXEC
	Machine: EM_X86_64			Machine: EM_X86_64
	Symbols:			Symbols:
	Global:			Global:
	- Name: test			- Name: test
	Index: 0xff05			Index: 0xff05

	# CHECK: [[_:.*]] Symbol 'test' has unsupported value greater than or equal to SHN_LORESERVE: 65285			# CHECK: Symbol 'test' has unsupported value greater than or equal to SHN_LORESERVE: 65285