[zorg] Allow specification of svn update mode remotely

[zturner]

Summary

This would allow people to trigger remote clobbers without having to log into a build bot.

[gkistanova]

Not sure the naming is good, though. Since this is a build property, it might be a good idea to be a bit more specific of what kind of mode is that, what do you think?
How about "checkout_mode" or "svn_mode"?

And just as a generic note. With this patch only some builders would accept this property.

[zturner]

I later found out that you can force a complete deletion of the source tree by building from revision 0. Do you think this functionality is still useful given this realization?

[gkistanova]

When you force to build a revision 0, you would get a red build before the next one will do a clean checkout. Which is not always good.

Some builders currently support a "clean" property and force a fully clean build in response, including the clean checkout.
With all the same, I'd prefer a consistent way of doing things. But it would take some time to add the support for the "clean" property to older factories, though.

Anyway, given that the immediate need in this change now is not that urgent, let's sit on for a while, shall we?

zorg/buildbot/builders/ClangBuilder.py

if trunk_revision:
                                haltOnFailure=True,
                                workdir='.'))
         f.addStep(ShellCommand(name='svn-clang-tools-extra',
                                command=svn_co_clang_tools_extra,
                                haltOnFailure=True,
                                workdir='.'))
     else:
         f.addStep(SVN(name='svn-llvm',
-                      mode='update',
+                      mode=Property('mode', default='update'),
                       baseURL='http://llvm.org/svn/llvm-project/llvm/',
                       defaultBranch='trunk',
                       workdir=llvm_srcdir))
         f.addStep(SVN(name='svn-clang',
-                      mode='update',
+                      mode=Property('mode', default='update'),
                       baseURL='http://llvm.org/svn/llvm-project/cfe/',
                       defaultBranch='trunk',
                       workdir='%s/tools/clang' % llvm_srcdir))
         f.addStep(SVN(name='svn-clang-tools-extra',
-                      mode='update',
+                      mode=Property('mode', default='update'),
                       baseURL='http://llvm.org/svn/llvm-project/clang-tools-extra/',
                       defaultBranch='trunk',
                       workdir='%s/tools/clang/tools/extra' % llvm_srcdir))
         if checkout_compiler_rt:
             f.addStep(SVN(name='svn-compiler-rt',
-                          mode='update',
+                          mode=Property('mode', default='update'),
                           baseURL='http://llvm.org/svn/llvm-project/compiler-rt/',
                           defaultBranch='trunk',
                           workdir='%s/projects/compiler-rt' % llvm_srcdir))
 
     # Clean up llvm (stage 1); unless in-dir.
     if clean and llvm_srcdir != llvm_1_objdir:
         f.addStep(ShellCommand(name="rm-llvm.obj.stage1",
                                command=["rm", "-rf", llvm_1_objdir],

 def addSVNUpdateSteps(f,
                       checkout_clang_tools_extra,
                       checkout_compiler_rt,
                       checkout_test_suite,
                       checkout_lld,
                       checkout_libcxx):
     # We *must* checkout at least Clang+LLVM
     f.addStep(SVN(name='svn-llvm',
-                  mode='update', baseURL='http://llvm.org/svn/llvm-project/llvm/',
+                  mode=Property('mode', default='update'), baseURL='http://llvm.org/svn/llvm-project/llvm/',
                   defaultBranch='trunk',
                   workdir='llvm'))
     f.addStep(SVN(name='svn-clang',
-                  mode='update', baseURL='http://llvm.org/svn/llvm-project/cfe/',
+                  mode=Property('mode', default='update'), baseURL='http://llvm.org/svn/llvm-project/cfe/',
                   defaultBranch='trunk',
                   workdir='llvm/tools/clang'))
 
     # Extra stuff that will be built/tested
     if checkout_clang_tools_extra:
         f.addStep(SVN(name='svn-clang-tools-extra',
-                      mode='update', baseURL='http://llvm.org/svn/llvm-project/clang-tools-extra/',
+                      mode=Property('mode', default='update'), baseURL='http://llvm.org/svn/llvm-project/clang-tools-extra/',
                       defaultBranch='trunk',
                       workdir='llvm/tools/clang/tools/extra'))
     if checkout_compiler_rt:
         f.addStep(SVN(name='svn-compiler-rt',
-                      mode='update', baseURL='http://llvm.org/svn/llvm-project/compiler-rt/',
+                      mode=Property('mode', default='update'), baseURL='http://llvm.org/svn/llvm-project/compiler-rt/',
                       defaultBranch='trunk',
                       workdir='llvm/projects/compiler-rt'))
     if checkout_test_suite:
         f.addStep(SVN(name='svn-lnt',
-                      mode='update', baseURL='http://llvm.org/svn/llvm-project/lnt/',
+                      mode=Property('mode', default='update'), baseURL='http://llvm.org/svn/llvm-project/lnt/',
                       defaultBranch='trunk',
                       workdir='test/lnt'))
         f.addStep(SVN(name='svn-test-suite',
-                      mode='update', baseURL='http://llvm.org/svn/llvm-project/test-suite/',
+                      mode=Property('mode', default='update'), baseURL='http://llvm.org/svn/llvm-project/test-suite/',
                       defaultBranch='trunk',
                       workdir='test/test-suite'))
     if checkout_lld:
         f.addStep(SVN(name='svn-lld',
-                      mode='update', baseURL='http://llvm.org/svn/llvm-project/lld/',
+                      mode=Property('mode', default='update'), baseURL='http://llvm.org/svn/llvm-project/lld/',
                       defaultBranch='trunk',
                       workdir='llvm/tools/lld'))
     if checkout_libcxx:
         f.addStep(SVN(name='svn-libcxx',
-                      mode='update',
+                      mode=Property('mode', default='update'),
                       baseURL='http://llvm.org/svn/llvm-project/libcxx/',
                       defaultBranch='trunk',
                       workdir='llvm/projects/libcxx'))
         f.addStep(SVN(name='svn-libcxxabi',
-                      mode='update',
+                      mode=Property('mode', default='update'),
                       baseURL='http://llvm.org/svn/llvm-project/libcxxabi/',
                       defaultBranch='trunk',
                       workdir='llvm/projects/libcxxabi'))
         f.addStep(SVN(name='svn-libunwind',
-                      mode='update',
+                      mode=Property('mode', default='update'),
                       baseURL='http://llvm.org/svn/llvm-project/libunwind/',
                       defaultBranch='trunk',
                       workdir='llvm/projects/libunwind'))
 
 def addGCSUploadSteps(f, package_name, install_prefix, gcs_directory, env,
                       gcs_url_property=None):
     """
     Add steps to upload to the Google Cloud Storage bucket.