This is an archive of the discontinued LLVM Phabricator instance.

Update_llc_tests for psubus.ll test
ClosedPublic

Authored by yulia_koval on Sep 6 2017, 11:01 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

yulia_koval created this revision.Sep 6 2017, 11:01 AM
spatel added a subscriber: spatel.Sep 6 2017, 11:14 AM
spatel added inline comments.
test/CodeGen/X86/psubus.ll
2–6 ↗(On Diff #114031)

The runs should be changed to '-mtriple=x86_64-unknown-unknown'; the tests don't depend on any particular OS. That should eliminate the "End function" noise (although we should fix the script to not include that too).

zvi added inline comments.Sep 6 2017, 11:24 AM
test/CodeGen/X86/psubus.ll
2–6 ↗(On Diff #114031)

I am asking out of ignorance, how would changing the the triple affects the verbosity of the asmprinter? Is there a different default per triple?

Tried this, it caused other changes, is it ok?

spatel added inline comments.Sep 6 2017, 11:37 AM
test/CodeGen/X86/psubus.ll
2–6 ↗(On Diff #114031)

I haven't looked at how the output changes exactly per triple, but one diff that I'm certain of is that when you use macOS/darwin, you get '##' comments instead of '#'...which is the only triple-related diff shown in this updated rev AFAICT. The extra constant printing for vector broadcast was an enhancement added somewhere along the way after this file was updated last.

I think the script just needs to adjust its regex to account for that extra '#'. OTOH having it produce extra noise for Apple tests usually points out the enhancement opportunity we have here. There aren't many valid cases in the regression tests where the OS is actually what we're interested in.

spatel accepted this revision.Sep 6 2017, 11:39 AM

LGTM.

This revision is now accepted and ready to land.Sep 6 2017, 11:39 AM

I can't commit, could you commit this for me please?

This revision was automatically updated to reflect the committed changes.