Hi, this is a patch to remove the "End function" diffs from the patch https://reviews.llvm.org/D37510?vs=113989&id=113990&whitespace=ignore-most#inline-326897
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
test/CodeGen/X86/psubus.ll | ||
---|---|---|
2–6 ↗ | (On Diff #114031) | The runs should be changed to '-mtriple=x86_64-unknown-unknown'; the tests don't depend on any particular OS. That should eliminate the "End function" noise (although we should fix the script to not include that too). |
test/CodeGen/X86/psubus.ll | ||
---|---|---|
2–6 ↗ | (On Diff #114031) | I am asking out of ignorance, how would changing the the triple affects the verbosity of the asmprinter? Is there a different default per triple? |
test/CodeGen/X86/psubus.ll | ||
---|---|---|
2–6 ↗ | (On Diff #114031) | I haven't looked at how the output changes exactly per triple, but one diff that I'm certain of is that when you use macOS/darwin, you get '##' comments instead of '#'...which is the only triple-related diff shown in this updated rev AFAICT. The extra constant printing for vector broadcast was an enhancement added somewhere along the way after this file was updated last. I think the script just needs to adjust its regex to account for that extra '#'. OTOH having it produce extra noise for Apple tests usually points out the enhancement opportunity we have here. There aren't many valid cases in the regression tests where the OS is actually what we're interested in. |