This is an archive of the discontinued LLVM Phabricator instance.

Differential D3749

Fix wrong setcc result type when legalizing uaddo/usubo
ClosedPublic

Authored by tmaconfire on May 13 2014, 2:23 PM.

Details

Reviewers
arsenm
Summary

There's no test because no other in tree targets change the bitwidth of the setcc type depending on the bitwidth of the compared type.

Diff Detail

Event Timeline

tmaconfire updated this revision to Diff 9364.May 13 2014, 2:23 PM
tmaconfire retitled this revision from to Fix wrong setcc result type when legalizing uaddo/usubo.
tmaconfire updated this object.
tmaconfire edited the test plan for this revision. (Show Details)
tmaconfire added a subscriber: Unknown Object (MLST).
tmaconfire added a comment.May 21 2014, 10:17 AM

ping.

tmaconfire added a comment.May 27 2014, 12:59 PM

Any reviews? Thanks!

arsenm accepted this revision.May 28 2014, 1:41 PM
arsenm added a reviewer: arsenm.
arsenm added a subscriber: arsenm.

LGTM

This revision is now accepted and ready to land.May 28 2014, 1:41 PM
arsenm closed this revision.May 28 2014, 1:59 PM

r209771

Revision Contents

PathSize
16 lines

Diff 9364

LegalizeDAG.cpp

Context not available.
ISD::ADD : ISD::SUB, dl, LHS.getValueType(), ISD::ADD : ISD::SUB, dl, LHS.getValueType(),
LHS, RHS); LHS, RHS);
Results.push_back(Sum); Results.push_back(Sum);
EVT OType = Node->getValueType(1); EVT ResultType = Node->getValueType(1);
EVT OType = getSetCCResultType(Node->getValueType(0));
SDValue Zero = DAG.getConstant(0, LHS.getValueType()); SDValue Zero = DAG.getConstant(0, LHS.getValueType());
Context not available.
SDValue SumSignNE = DAG.getSetCC(dl, OType, LHSSign, SumSign, ISD::SETNE); SDValue SumSignNE = DAG.getSetCC(dl, OType, LHSSign, SumSign, ISD::SETNE);
SDValue Cmp = DAG.getNode(ISD::AND, dl, OType, SignsMatch, SumSignNE); SDValue Cmp = DAG.getNode(ISD::AND, dl, OType, SignsMatch, SumSignNE);
Results.push_back(Cmp); Results.push_back(DAG.getBoolExtOrTrunc(Cmp, dl, ResultType));
break; break;
} }
case ISD::UADDO: case ISD::UADDO:
Context not available.
ISD::ADD : ISD::SUB, dl, LHS.getValueType(), ISD::ADD : ISD::SUB, dl, LHS.getValueType(),
LHS, RHS); LHS, RHS);
Results.push_back(Sum); Results.push_back(Sum);
Results.push_back(DAG.getSetCC(dl, Node->getValueType(1), Sum, LHS,
Node->getOpcode () == ISD::UADDO ? EVT ResultType = Node->getValueType(1);
ISD::SETULT : ISD::SETUGT)); EVT SetCCType = getSetCCResultType(Node->getValueType(0));
ISD::CondCode CC
= Node->getOpcode() == ISD::UADDO ? ISD::SETULT : ISD::SETUGT;
SDValue SetCC = DAG.getSetCC(dl, SetCCType, Sum, LHS, CC);
Results.push_back(DAG.getBoolExtOrTrunc(SetCC, dl, ResultType));
break; break;
} }
case ISD::UMULO: case ISD::UMULO:
Context not available.