Page MenuHomePhabricator

D37461: fixups for existing InlineAsm tests + adding new ones
Needs ReviewPublic

Authored by coby on Sep 5 2017, 4:32 AM.

Details

Reviewers
rnk

Diff Detail

Repository
rL LLVM

Event Timeline

coby created this revision.Sep 5 2017, 4:32 AM
rnk added inline comments.Sep 19 2017, 12:00 PM
test/CodeGen/ms-inline-asm.cpp
37–38

These don't seem tested anywhere now

coby added inline comments.Oct 1 2017, 5:45 AM
test/CodeGen/ms-inline-asm.cpp
37–38

I've tested them against msvc, and they are seem to be unsupported there as well, so I don't see any value in keeping this one around :\

rnk added inline comments.Oct 2 2017, 9:31 AM
test/CodeGen/ms-inline-asm.cpp
37–38

Got it. Can we make a negative test for offset with namespace separators then?