[LNT] Invalid field being used on the samples graph API

[leandron]

Summary

Fixes the way field_index is generated for a given field_name.

Make sure it uses the same list as the graph api will use to recover the information afterwards.

[cmatthews]

My bad. Thank you!

[cmatthews]

Also, need to modify the if not field_index, because now field_index can be 0, which is Falsey.

[MatzeB]

Ah yeah I had to abandon field.index in r312059; it can usually be replaced by TestSuiteDB.get_field_index(field). Doing it like proposed here is fine too (except for the if not field_index test being bad now as Chris already mentioned).

[leandron]

I've used ts.sample_fields just because is the same list the v4_graph will use to grab the value back.
Sending a new version in a minute.

[leandron]

Commited as r312314

lnt/server/ui/views.py

def v4_graph_for_sample(sample_id, field_name):
 
     """
     ts = request.get_testsuite()
     target_sample = ts.query(ts.Sample).get(sample_id)
     if not target_sample:
         abort(404, "Could not find sample id: {}".format(sample_id))
 
     # Get the field index we are interested in.
-    field = None
-    for f in target_sample.get_primary_fields():
+    field_index = None
+    for idx, f in enumerate(ts.sample_fields):
         if f.name == field_name:
-            field = f
+            field_index = idx
             break
-    if not field:
+    if field_index is None:
         abort(400, "Could not find field {}".format(field_name))
-    field_index = field.index
 
     kwargs = {'plot.0': '{machine_id}.{test_id}.{field_id}'.format(
         machine_id=target_sample.run.machine.id,
         test_id=target_sample.test_id,
         field_id=field_index)}
     # Pass request args through, so you can add graph options.
     kwargs.update(request.args)