Page MenuHomePhabricator

[AVX512] Don't switch unmasked subvector insert/extract instructions when AVX512DQI is enabled.
ClosedPublic

Authored by craig.topper on Aug 13 2017, 11:03 PM.

Details

Summary

There's no reason to switch instructions with and without DQI. It just creates extra isel patterns and test divergences.

There is however value in enabling the masked version of the instructions with DQI.

This required introducing some new multiclasses to enabling this splitting. If anyone has a better suggestion of how to do this I'm open to it.

Diff Detail

Repository
rL LLVM

Event Timeline

craig.topper created this revision.Aug 13 2017, 11:03 PM
igorb accepted this revision.Aug 17 2017, 2:55 AM

LGTM ,
Could you please make sure that tests cover the masked version of the instructions with DQI.

This revision is now accepted and ready to land.Aug 17 2017, 2:55 AM
This revision was automatically updated to reflect the committed changes.