Page MenuHomePhabricator

Syntax of asm instrumentation code is changed from AT&T to Intel.
AbandonedPublic

Authored by ygorshenin on Apr 30 2014, 6:31 AM.

Details

Reviewers
eugenis
Summary

Syntax of asm instrumentation code is changed from AT&T to Intel.

Diff Detail

Event Timeline

ygorshenin updated this revision to Diff 8974.Apr 30 2014, 6:31 AM
ygorshenin retitled this revision from to Syntax of asm instrumentation code is changed from AT&T to Intel..
ygorshenin updated this object.
ygorshenin edited the test plan for this revision. (Show Details)
ygorshenin added a reviewer: eugenis.
ygorshenin added a subscriber: Unknown Object (MLST).

Please no. It's really weird to have Intel syntax in the code used mostly on Linux without a strong reason.

eugenis edited edge metadata.May 7 2014, 1:27 AM

AFAIU, this is an unfinished attempt to support windows build.
We'll try to directly emit everything this file does in MC instead.

ygorshenin abandoned this revision.May 20 2014, 6:49 AM

Closing the revision as it was decided to get rid of this .S file.

We'll try to directly emit everything this file does in MC instead.

What about gcc though?

These functions are used in asm instrumentation, which gcc can not do (well, it _could_ be done in gnu assembler).

Are you saying they can be used for the instrument-with-calls mode?

These functions are used in asm instrumentation, which gcc can not do (well, it _could_ be done in gnu assembler).

My understanding was that they can also be used in inline asm which sounds like an important feature. Am I wrong?

Are you saying they can be used for the instrument-with-calls mode?

No, certainly not, that would be too slow.

Yes, they are used for both inline asm and .s files.
Do you know of any plans to implement that in gcc-asan? As I understand, they don't have an integrated assembler and simply emit inline asm as text to .s.

Do you know of any plans to implement that in gcc-asan?

You mean integrated asm? I don't think there are any plans for this in GCC. So I only care about ability to manually add instrumentation in inline asm and/or .S when necessary.

As I understand, they don't have an integrated assembler and simply emit inline asm as text to .s.

Yup.