Page MenuHomePhabricator

[Driver] Always use -z rodynamic for Fuchsia
ClosedPublic

Authored by phosek on Jul 18 2017, 2:07 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Jul 18 2017, 2:07 PM
mcgrathr requested changes to this revision.Jul 18 2017, 2:31 PM

Looks almost right. Might be overkill to add a test case that -z rodynamic is omitted with -fuse-ld=gold or something.

lib/Driver/ToolChains/Fuchsia.cpp
51 ↗(On Diff #107177)

Should be inside the lld conditional, since only lld groks -z rodynamic.

This revision now requires changes to proceed.Jul 18 2017, 2:31 PM
phosek updated this revision to Diff 107185.Jul 18 2017, 2:33 PM
phosek edited edge metadata.
phosek marked an inline comment as done.
This revision is now accepted and ready to land.Jul 18 2017, 2:51 PM
This revision was automatically updated to reflect the committed changes.