Page MenuHomePhabricator

Remove uint32_t assignment operator from Status
ClosedPublic

Authored by labath on Jul 12 2017, 7:27 AM.

Details

Summary

It is not presently used, and it's quite dangerous to use -- it assumes the
integer is an osx kern_return_t, but very few of the integers we have lying
around are mach kernel error codes. The error can still be used to a
mach error using a slightly longer (but more explicit) syntax.

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.Jul 12 2017, 7:27 AM
jingham accepted this revision.Oct 31 2017, 10:57 AM

Sure, this seems fine to me. Not sure why this was introduced, the svn history has become hard to follow. But this seems overly specific for an integer assignment operator.

This revision is now accepted and ready to land.Oct 31 2017, 10:57 AM
This revision was automatically updated to reflect the committed changes.