This is an archive of the discontinued LLVM Phabricator instance.

Differential D34942

[PYTHON] Fix crash with "Fatal Python error: Python memory allocator called without holding the GIL"
ClosedPublic

Authored by tatyana-krasnukha on Jul 3 2017, 6:46 AM.

Details

Reviewers
None
Commits
rGac43c1bb87ac: Don't access Python objects while not holding the GIL.
rLLDB307512: Don't access Python objects while not holding the GIL.
rL307512: Don't access Python objects while not holding the GIL.
Summary

This patch fixes Bug 32920.

Diff Detail

Repository
rL LLVM

Event Timeline

tatyana-krasnukha created this revision.Jul 3 2017, 6:46 AM
tatyana-krasnukha edited the summary of this revision. (Show Details)Jul 3 2017, 8:40 AM
tatyana-krasnukha retitled this revision from [PYTHON][Windows] Fix crash with "Fatal Python error: Python memory allocator called without holding the GIL" to [PYTHON] Fix crash with "Fatal Python error: Python memory allocator called without holding the GIL".
Closed by commit rL307512: Don't access Python objects while not holding the GIL. (authored by zturner). · Explain WhyJul 9 2017, 4:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
trunk/
source/
Plugins/
ScriptInterpreter/
Python/
14 lines

Diff 105799

lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp

Show First 20 Lines • Show All 1,851 Lines • ▼ Show 20 LinesStructuredData::DictionarySP ScriptInterpreterPython::GetDynamicSettings(
if (!plugin_module_sp || !target || !setting_name || !setting_name[0] || if (!plugin_module_sp || !target || !setting_name || !setting_name[0] ||
!g_swig_plugin_get) !g_swig_plugin_get)
return StructuredData::DictionarySP(); return StructuredData::DictionarySP();
StructuredData::Generic *generic = plugin_module_sp->GetAsGeneric(); StructuredData::Generic *generic = plugin_module_sp->GetAsGeneric();
if (!generic) if (!generic)
return StructuredData::DictionarySP(); return StructuredData::DictionarySP();
PythonObject reply_pyobj; PythonObject reply_pyobj;
{
Locker py_lock(this, Locker py_lock(this,
Locker::AcquireLock | Locker::InitSession | Locker::NoSTDIN); Locker::AcquireLock | Locker::InitSession | Locker::NoSTDIN);
TargetSP target_sp(target->shared_from_this()); TargetSP target_sp(target->shared_from_this());
reply_pyobj.Reset(PyRefType::Owned, reply_pyobj.Reset(PyRefType::Owned,
(PyObject *)g_swig_plugin_get(generic->GetValue(), (PyObject *)g_swig_plugin_get(generic->GetValue(),
setting_name, target_sp)); setting_name, target_sp));
}
PythonDictionary py_dict(PyRefType::Borrowed, reply_pyobj.get()); PythonDictionary py_dict(PyRefType::Borrowed, reply_pyobj.get());
return py_dict.CreateStructuredDictionary(); return py_dict.CreateStructuredDictionary();
} }
StructuredData::ObjectSP StructuredData::ObjectSP
ScriptInterpreterPython::CreateSyntheticScriptedProvider( ScriptInterpreterPython::CreateSyntheticScriptedProvider(
const char *class_name, lldb::ValueObjectSP valobj) { const char *class_name, lldb::ValueObjectSP valobj) {
▲ Show 20 Lines • Show All 1,313 Lines • Show Last 20 Lines