Page MenuHomePhabricator

[tablegen] !strconcat accepts more than two arguments but this wasn't documented or tested.
ClosedPublic

Authored by dsanders on Apr 24 2014, 9:15 AM.

Details

Summary
  • Updated the documentation
  • Added a test for >2 arguments
  • Added a check for the lexical concatenation
  • Made the existing test a bit stricter.

Diff Detail

Event Timeline

dsanders updated this revision to Diff 8807.Apr 24 2014, 9:15 AM
dsanders retitled this revision from to [tablegen] !strconcat accepts more than two arguments but this wasn't documented or tested..
dsanders updated this object.
dsanders edited the test plan for this revision. (Show Details)
dsanders added a subscriber: Unknown Object (MLST).

Hi Daniel,

Sorry about the delay, improving documentation's a worthy cause.

docs/TableGen/LangIntro.rst
163

This should probably be updated to either !strconcat(a, ...) or !strconcat(a, b, ...). Is a single argument supported, BTW?

Hi Tim,

Thanks for the review.

docs/TableGen/LangIntro.rst
163

I agree, I'll update it to !strconcat(a, b, ...)

Is a single argument supported, BTW?

No, it reports an error if it only gets one argument.

dsanders updated this revision to Diff 9037.May 2 2014, 11:35 AM
  • !strconcat(a, b) -> !strconcat(a, b, ...)
t.p.northover accepted this revision.May 2 2014, 11:42 AM
t.p.northover added a reviewer: t.p.northover.

Excellent! Thanks Daniel. That answers all the questions I had looking at the updated documentation so go for it!

Cheers.

Tim.

This revision is now accepted and ready to land.May 2 2014, 11:42 AM
dsanders closed this revision.May 2 2014, 12:32 PM