This is an archive of the discontinued LLVM Phabricator instance.

[llvm-cvtres] Put resource symbols in .rsrc$02
ClosedPublic

Authored by sirg3 on Jun 29 2017, 1:08 PM.

Details

Summary

The $RXXXXXX symbols generated by llvm-cvtres need to go in .rsrc$02 instead of .rsrc$01.

Event Timeline

sirg3 created this revision.Jun 29 2017, 1:08 PM
ecbeckmann edited edge metadata.Jun 29 2017, 2:05 PM

Wow. Good catch. I was wondering why these patches were breaking chromium lld windows bots, and this probably explains it. Thanks a lot!

ecbeckmann accepted this revision.Jun 29 2017, 2:06 PM
This revision is now accepted and ready to land.Jun 29 2017, 2:06 PM

Do you think you could submit this soon, or I can submit for you? I'd like to switch the build back to my code path pretty soon if this fixes everything.

Do you think you could submit this soon, or I can submit for you? I'd like to switch the build back to my code path pretty soon if this fixes everything.

I don't know anything about the Phabricator-driven review system and how things get submitted -- until now I've just sent patches to the commits list. Could you do it?

Do you think you could submit this soon, or I can submit for you? I'd like to switch the build back to my code path pretty soon if this fixes everything.

I don't know anything about the Phabricator-driven review system and how things get submitted -- until now I've just sent patches to the commits list. Could you do it?

Ah okay, yes sure.

This revision was automatically updated to reflect the committed changes.