Page MenuHomePhabricator

[mips] Support 128-bit int in N32 ABI by overriding TargetInfo::hasInt128Type()
ClosedPublic

Authored by dsanders on Apr 23 2014, 9:35 AM.

Details

Summary

The condition in the base class is rather strange. It says a target has the 128-bit integer type if the size of a pointer is >= 64-bits. N32 has 32-bit pointers but 64-bit integers. I'm a bit reluctant to change this for all targets so this patch makes the method virtual and overrides it for MIPS64.

Diff Detail

Event Timeline

dsanders updated this revision to Diff 8777.Apr 23 2014, 9:35 AM
dsanders retitled this revision from to [mips] Support 128-bit int in N32 ABI by overriding TargetInfo::hasInt128Type().
dsanders updated this object.
dsanders edited the test plan for this revision. (Show Details)
dsanders updated this object.Apr 24 2014, 3:14 AM
dsanders updated this revision to Diff 8798.Apr 24 2014, 3:16 AM
  • Split int128 out to a separate test since O32 doesn't support it and fix two silly mistakes.

Could you review this for me?

It touches common code so I'm also going to CC llvm-commits.

dsanders added a subscriber: Unknown Object (MLST).Apr 24 2014, 3:18 AM

Added llvm-commits.

atanasyan accepted this revision.Apr 24 2014, 6:40 AM
atanasyan edited edge metadata.

LGTM

This revision is now accepted and ready to land.Apr 24 2014, 6:40 AM
dsanders closed this revision.Apr 24 2014, 9:12 AM