Page MenuHomePhabricator

[ARM64] Enable alignment control option in front-end for ARM64 - Clang.
Needs ReviewPublic

Authored by kevin.qin on Apr 23 2014, 3:05 AM.

Details

Reviewers
t.p.northover
Summary

Hi Tim and other reviewers,

This patch is to get "-mno-unaligned-access" and "-munaligned-access" work in front-end for ARM64 target.

One thing worth to mention is, as ARM and ARM64 shared same command option in front end, does it need to share same command option in backend? If we decide to do this, the opt option "arm-strict-align" and "arm64-strict-align" would be combined to a single opt option("arm-strict-align" for example) which is shared in two backends. My question is, is it necessary to do this? And if we want do this, how to share opt object between two backends in a good way? If there is any other idea around this, please let me know. Thanks.

Diff Detail

Event Timeline

kevin.qin updated this revision to Diff 8767.Apr 23 2014, 3:05 AM
kevin.qin retitled this revision from to [ARM64] Enable alignment control option in front-end for ARM64 - Clang..
kevin.qin updated this object.
kevin.qin edited the test plan for this revision. (Show Details)
kevin.qin added a reviewer: t.p.northover.
kevin.qin added subscribers: Unknown Object (MLST), Unknown Object (MLST).Apr 23 2014, 3:08 AM
t.p.northover edited edge metadata.May 6 2014, 2:15 AM

Hi Kevin,

I think this looks reasonable, given current implementations. It might be better to combine into a completely generic backend "strict-align" option, particularly if more targets come along wanting the functionality. But I'm not really sure where such a thing should live.

Cheers.

Tim.