This is an archive of the discontinued LLVM Phabricator instance.

Differential D34562

[MSP430] Fix data layout string.
ClosedPublic

Authored by pftbest on Jun 23 2017, 11:20 AM.

Download Raw Diff

Details

Reviewers

asl
awygle

Commits

rG00b396c0a0d7: [MSP430] Fix data layout string.
rC306161: [MSP430] Fix data layout string.
rL306161: [MSP430] Fix data layout string.

Summary

Change data layout string so it would be compatible with MSP430 EABI.

Depends on D34561

Diff Detail

Build Status

Buildable 7535
Build 7535: arc lint + arc unit

Event Timeline

pftbest created this revision.Jun 23 2017, 11:20 AM

asl accepted this revision.Jun 23 2017, 11:22 AM

This revision is now accepted and ready to land.Jun 23 2017, 11:22 AM

Meta-question: shall we support only EABI or... 2 different ABIs? It seems it does not make any sense to support anything besides EABI.

Thanks!

shall we support only EABI or... 2 different ABIs?

GCC supports only EABI, and i think we should also spend our limited resources on more important issues, than supporting old abi.

Closed by commit rL306161: [MSP430] Fix data layout string. (authored by dambrouski). · Explain WhyJun 23 2017, 2:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lib/

Basic/

2 lines

test/

CodeGen/

2 lines

Diff 103751

lib/Basic/Targets.cpp

This file is larger than 256 KB, so syntax highlighting is disabled by default.

	Show First 20 Lines • Show All 7,497 Lines • ▼ Show 20 Lines		MSP430TargetInfo(const llvm::Triple &Triple, const TargetOptions &)
	PointerWidth = 16;			PointerWidth = 16;
	PointerAlign = 16;			PointerAlign = 16;
	SuitableAlign = 16;			SuitableAlign = 16;
	SizeType = UnsignedInt;			SizeType = UnsignedInt;
	IntMaxType = SignedLongLong;			IntMaxType = SignedLongLong;
	IntPtrType = SignedInt;			IntPtrType = SignedInt;
	PtrDiffType = SignedInt;			PtrDiffType = SignedInt;
	SigAtomicType = SignedLong;			SigAtomicType = SignedLong;
	resetDataLayout("e-m:e-p:16:16-i32:16:32-a:16-n8:16");			resetDataLayout("e-m:e-p:16:16-i32:16-i64:16-f32:16-f64:16-a:8-n8:16-S16");
	}			}
	void getTargetDefines(const LangOptions &Opts,			void getTargetDefines(const LangOptions &Opts,
	MacroBuilder &Builder) const override {			MacroBuilder &Builder) const override {
	Builder.defineMacro("MSP430");			Builder.defineMacro("MSP430");
	Builder.defineMacro("__MSP430__");			Builder.defineMacro("__MSP430__");
	// FIXME: defines for different 'flavours' of MCU			// FIXME: defines for different 'flavours' of MCU
	}			}
	ArrayRef<Builtin::Info> getTargetBuiltins() const override {			ArrayRef<Builtin::Info> getTargetBuiltins() const override {
	▲ Show 20 Lines • Show All 2,212 Lines • Show Last 20 Lines

test/CodeGen/target-data.c

	Show First 20 Lines • Show All 169 Lines • ▼ Show 20 Lines
	// RUN: %clang_cc1 -triple s390x-unknown -target-cpu z13 -o - -emit-llvm %s \| \			// RUN: %clang_cc1 -triple s390x-unknown -target-cpu z13 -o - -emit-llvm %s \| \
	// RUN: FileCheck %s -check-prefix=SYSTEMZ-VECTOR			// RUN: FileCheck %s -check-prefix=SYSTEMZ-VECTOR
	// RUN: %clang_cc1 -triple s390x-unknown -target-cpu arch11 -o - -emit-llvm %s \| \			// RUN: %clang_cc1 -triple s390x-unknown -target-cpu arch11 -o - -emit-llvm %s \| \
	// RUN: FileCheck %s -check-prefix=SYSTEMZ-VECTOR			// RUN: FileCheck %s -check-prefix=SYSTEMZ-VECTOR
	// SYSTEMZ-VECTOR: target datalayout = "E-m:e-i1:8:16-i8:8:16-i64:64-f128:64-v128:64-a:8:16-n32:64"			// SYSTEMZ-VECTOR: target datalayout = "E-m:e-i1:8:16-i8:8:16-i64:64-f128:64-v128:64-a:8:16-n32:64"

	// RUN: %clang_cc1 -triple msp430-unknown -o - -emit-llvm %s \| \			// RUN: %clang_cc1 -triple msp430-unknown -o - -emit-llvm %s \| \
	// RUN: FileCheck %s -check-prefix=MSP430			// RUN: FileCheck %s -check-prefix=MSP430
	// MSP430: target datalayout = "e-m:e-p:16:16-i32:16:32-a:16-n8:16"			// MSP430: target datalayout = "e-m:e-p:16:16-i32:16-i64:16-f32:16-f64:16-a:8-n8:16-S16"

	// RUN: %clang_cc1 -triple tce-unknown -o - -emit-llvm %s \| \			// RUN: %clang_cc1 -triple tce-unknown -o - -emit-llvm %s \| \
	// RUN: FileCheck %s -check-prefix=TCE			// RUN: FileCheck %s -check-prefix=TCE
	// TCE: target datalayout = "E-p:32:32:32-i1:8:8-i8:8:32-i16:16:32-i32:32:32-i64:32:32-f32:32:32-f64:32:32-v64:32:32-v128:32:32-v256:32:32-v512:32:32-v1024:32:32-a0:0:32-n32"			// TCE: target datalayout = "E-p:32:32:32-i1:8:8-i8:8:32-i16:16:32-i32:32:32-i64:32:32-f32:32:32-f64:32:32-v64:32:32-v128:32:32-v256:32:32-v512:32:32-v1024:32:32-a0:0:32-n32"

	// RUN: %clang_cc1 -triple tcele-unknown -o - -emit-llvm %s \| \			// RUN: %clang_cc1 -triple tcele-unknown -o - -emit-llvm %s \| \
	// RUN: FileCheck %s -check-prefix=TCELE			// RUN: FileCheck %s -check-prefix=TCELE
	// TCELE: target datalayout = "e-p:32:32:32-i1:8:8-i8:8:32-i16:16:32-i32:32:32-i64:32:32-f32:32:32-f64:32:32-v64:32:32-v128:32:32-v256:32:32-v512:32:32-v1024:32:32-a0:0:32-n32"			// TCELE: target datalayout = "e-p:32:32:32-i1:8:8-i8:8:32-i16:16:32-i32:32:32-i64:32:32-f32:32:32-f64:32:32-v64:32:32-v128:32:32-v256:32:32-v512:32:32-v1024:32:32-a0:0:32-n32"
	Show All 16 Lines