Page MenuHomePhabricator

Support outline instrumentation for wide types
ClosedPublic

Authored by ygribov on Apr 22 2014, 2:11 AM.

Details

Reviewers
kcc

Diff Detail

Event Timeline

kcc added a comment.Apr 22 2014, 2:19 AM

The code looks fine, please just add a test to llvm/test/Instrumentation/AddressSanitizer/instrumentation-with-call-threshold.ll
I actually considered to always emit calls for non 1-, 2-, 4-, -8, and 16-byte accesses to simplify the code and testing.
This will slowdown this use case somewhat, but those accesses are extremely rare anyway.
What do others think?

What about AVX codes?

kcc added a comment.Apr 22 2014, 2:33 AM

AVX access are power of two, right?
As soon as we get a hardware where we can test AVX, we'll add 32- and 64-byte accesses. They should not be instrumented with __asan_loadN

ygribov updated this revision to Unknown Object (????).Apr 22 2014, 3:47 AM

Added test.

kcc accepted this revision.Apr 22 2014, 4:19 AM

LGTM
I will add a test for i80 and commit

kcc closed this revision.Apr 22 2014, 4:26 AM

r206883.
thanks again.