This is an archive of the discontinued LLVM Phabricator instance.

Differential D34429

Fix warnings about hidden virtual methods in CodeView.
ClosedPublic

Authored by seandree on Jun 20 2017, 4:44 PM.

Details

Reviewers
zturner
rnk
Commits
rG8a7287e4c89f: Silence warnings about hidden virtual methods.
rL306038: Silence warnings about hidden virtual methods.
Summary

This warnings were introduced in PR https://reviews.llvm.org/D32928.
I have project that treats warnings as errors so I can't build llvm there.

In file included from /home/sergey/git/llvm/llvm/include/llvm/DebugInfo/CodeView/TypeRecordMapping.h:15:0,
                 from /home/sergey/git/llvm/llvm/include/llvm/DebugInfo/CodeView/TypeSerializer.h:13,
                 from /home/sergey/git/llvm/llvm/include/llvm/DebugInfo/CodeView/TypeTableBuilder.h:17,
                 from /home/sergey/git/llvm/llvm/tools/llilc/lib/ObjWriter/objwriter.h:16,
                 from /home/sergey/git/llvm/llvm/tools/llilc/lib/ObjWriter/objwriter.cpp:16:
/home/sergey/git/llvm/llvm/include/llvm/DebugInfo/CodeView/TypeVisitorCallbacks.h:33:17: error: ‘virtual llvm::Error llvm::codeview::TypeVisitorCallbacks::visitTypeBegin(llvm::codeview::CVType&, llvm::codeview::TypeIndex)’ was hidden [-Werror=overloaded-virtual]
   virtual Error visitTypeBegin(CVType &Record, TypeIndex Index) {
                 ^
In file included from /home/sergey/git/llvm/llvm/include/llvm/DebugInfo/CodeView/TypeSerializer.h:13:0,
                 from /home/sergey/git/llvm/llvm/include/llvm/DebugInfo/CodeView/TypeTableBuilder.h:17,
                 from /home/sergey/git/llvm/llvm/tools/llilc/lib/ObjWriter/objwriter.h:16,
                 from /home/sergey/git/llvm/llvm/tools/llilc/lib/ObjWriter/objwriter.cpp:16:
/home/sergey/git/llvm/llvm/include/llvm/DebugInfo/CodeView/TypeRecordMapping.h:28:9: error:   by ‘virtual llvm::Error llvm::codeview::TypeRecordMapping::visitTypeBegin(llvm::codeview::CVType&)’ [-Werror=overloaded-virtual]
   Error visitTypeBegin(CVType &Record) override;
         ^
In file included from /home/sergey/git/llvm/llvm/include/llvm/DebugInfo/CodeView/TypeRecordMapping.h:15:0,
                 from /home/sergey/git/llvm/llvm/include/llvm/DebugInfo/CodeView/TypeSerializer.h:13,
                 from /home/sergey/git/llvm/llvm/include/llvm/DebugInfo/CodeView/TypeTableBuilder.h:17,
                 from /home/sergey/git/llvm/llvm/tools/llilc/lib/ObjWriter/objwriter.h:16,
                 from /home/sergey/git/llvm/llvm/tools/llilc/lib/ObjWriter/objwriter.cpp:16:
/home/sergey/git/llvm/llvm/include/llvm/DebugInfo/CodeView/TypeVisitorCallbacks.h:33:17: error: ‘virtual llvm::Error llvm::codeview::TypeVisitorCallbacks::visitTypeBegin(llvm::codeview::CVType&, llvm::codeview::TypeIndex)’ was hidden [-Werror=overloaded-virtual]
   virtual Error visitTypeBegin(CVType &Record, TypeIndex Index) {
                 ^
In file included from /home/sergey/git/llvm/llvm/include/llvm/DebugInfo/CodeView/TypeTableBuilder.h:17:0,
                 from /home/sergey/git/llvm/llvm/tools/llilc/lib/ObjWriter/objwriter.h:16,
                 from /home/sergey/git/llvm/llvm/tools/llilc/lib/ObjWriter/objwriter.cpp:16:
/home/sergey/git/llvm/llvm/include/llvm/DebugInfo/CodeView/TypeSerializer.h:96:9: error:   by ‘virtual llvm::Error llvm::codeview::TypeSerializer::visitTypeBegin(llvm::codeview::CVType&)’ [-Werror=overloaded-virtual]
   Error visitTypeBegin(CVType &Record) override;

Diff Detail

Repository
rL LLVM

Event Timeline

seandree created this revision.Jun 20 2017, 4:44 PM
seandree edited the summary of this revision. (Show Details)Jun 20 2017, 5:02 PM
zturner accepted this revision.Jun 22 2017, 10:41 AM
This revision is now accepted and ready to land.Jun 22 2017, 10:41 AM
Closed by commit rL306038: Silence warnings about hidden virtual methods. (authored by zturner). · Explain WhyJun 22 2017, 10:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
include/
llvm/
DebugInfo/
CodeView/
1 line
1 line

Diff 103601

llvm/trunk/include/llvm/DebugInfo/CodeView/TypeRecordMapping.h

Show All 19 Lines
class BinaryStreamWriter; class BinaryStreamWriter;
namespace codeview { namespace codeview {
class TypeRecordMapping : public TypeVisitorCallbacks { class TypeRecordMapping : public TypeVisitorCallbacks {
public: public:
explicit TypeRecordMapping(BinaryStreamReader &Reader) : IO(Reader) {} explicit TypeRecordMapping(BinaryStreamReader &Reader) : IO(Reader) {}
explicit TypeRecordMapping(BinaryStreamWriter &Writer) : IO(Writer) {} explicit TypeRecordMapping(BinaryStreamWriter &Writer) : IO(Writer) {}
using TypeVisitorCallbacks::visitTypeBegin;
Error visitTypeBegin(CVType &Record) override; Error visitTypeBegin(CVType &Record) override;
Error visitTypeEnd(CVType &Record) override; Error visitTypeEnd(CVType &Record) override;
Error visitMemberBegin(CVMemberRecord &Record) override; Error visitMemberBegin(CVMemberRecord &Record) override;
Error visitMemberEnd(CVMemberRecord &Record) override; Error visitMemberEnd(CVMemberRecord &Record) override;
#define TYPE_RECORD(EnumName, EnumVal, Name) \ #define TYPE_RECORD(EnumName, EnumVal, Name) \
Error visitKnownRecord(CVType &CVR, Name##Record &Record) override; Error visitKnownRecord(CVType &CVR, Name##Record &Record) override;
Show All 16 Lines

llvm/trunk/include/llvm/DebugInfo/CodeView/TypeSerializer.h

Show First 20 Lines • Show All 87 Lines • ▼ Show 20 Linespublic:
BumpPtrAllocator &getAllocator() { return RecordStorage; } BumpPtrAllocator &getAllocator() { return RecordStorage; }
ArrayRef<ArrayRef<uint8_t>> records() const; ArrayRef<ArrayRef<uint8_t>> records() const;
TypeIndex insertRecordBytes(ArrayRef<uint8_t> &Record); TypeIndex insertRecordBytes(ArrayRef<uint8_t> &Record);
TypeIndex insertRecord(const RemappedType &Record); TypeIndex insertRecord(const RemappedType &Record);
Expected<TypeIndex> visitTypeEndGetIndex(CVType &Record); Expected<TypeIndex> visitTypeEndGetIndex(CVType &Record);
using TypeVisitorCallbacks::visitTypeBegin;
Error visitTypeBegin(CVType &Record) override; Error visitTypeBegin(CVType &Record) override;
Error visitTypeEnd(CVType &Record) override; Error visitTypeEnd(CVType &Record) override;
Error visitMemberBegin(CVMemberRecord &Record) override; Error visitMemberBegin(CVMemberRecord &Record) override;
Error visitMemberEnd(CVMemberRecord &Record) override; Error visitMemberEnd(CVMemberRecord &Record) override;
#define TYPE_RECORD(EnumName, EnumVal, Name) \ #define TYPE_RECORD(EnumName, EnumVal, Name) \
virtual Error visitKnownRecord(CVType &CVR, Name##Record &Record) override { \ virtual Error visitKnownRecord(CVType &CVR, Name##Record &Record) override { \
return visitKnownRecordImpl(CVR, Record); \ return visitKnownRecordImpl(CVR, Record); \
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines