This is an archive of the discontinued LLVM Phabricator instance.

Differential D34186

Re-enable tests on power pc since the bug has been fixed.
ClosedPublic

Authored by ecbeckmann on Jun 13 2017, 5:22 PM.

Details

Reviewers
None
Commits
rG919d8dd8d7fb: Re-enable tests on power pc since the bug has been fixed.
rL305345: Re-enable tests on power pc since the bug has been fixed.
Summary

just flip them on.

Diff Detail

Event Timeline

ecbeckmann created this revision.Jun 13 2017, 5:22 PM
Harbormaster completed remote builds in B7223: Diff 102461.Jun 13 2017, 5:22 PM
Closed by commit rL305345: Re-enable tests on power pc since the bug has been fixed. (authored by ecbeckmann). · Explain WhyJun 13 2017, 5:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-cvtres/
4 lines
4 lines

Diff 102461

llvm/test/tools/llvm-cvtres/combined.test

// Check that cvtres properly handles merging multiple .res files. // Check that cvtres properly handles merging multiple .res files.
// The inputs were generated with the following commands, using the original Windows // The inputs were generated with the following commands, using the original Windows
// rc.exe: // rc.exe:
// > rc /fo test_resource.res /nologo test_resource.rc // > rc /fo test_resource.res /nologo test_resource.rc
// > rc /fo languages.res /nologo languages.rc // > rc /fo languages.res /nologo languages.rc
// The object file we are comparing against was generated with this command using // The object file we are comparing against was generated with this command using
// the original Windows cvtres.exe. // the original Windows cvtres.exe.
// > cvtres /machine:X86 /readonly /nologo /out:combined.obj.coff \ // > cvtres /machine:X86 /readonly /nologo /out:combined.obj.coff \
// languages.res test_resource.res // languages.res test_resource.res
// FIXME: This test doesn't work on powerpc64 BE. Re-enable it once it
// is fixed. See pr33429.
UNSUPPORTED: powerpc64-unknown-linux-gnu
RUN: llvm-cvtres /verbose /out:%t %p/Inputs/languages.res %p/Inputs/test_resource.res RUN: llvm-cvtres /verbose /out:%t %p/Inputs/languages.res %p/Inputs/test_resource.res
RUN: llvm-readobj -coff-resources -section-data %t | FileCheck %s RUN: llvm-readobj -coff-resources -section-data %t | FileCheck %s
CHECK: Resources [ CHECK: Resources [
CHECK-NEXT: Total Number of Resources: 12 CHECK-NEXT: Total Number of Resources: 12
CHECK-DAG: Number of String Entries: 1 CHECK-DAG: Number of String Entries: 1
CHECK-NEXT: Number of ID Entries: 5 CHECK-NEXT: Number of ID Entries: 5
CHECK-NEXT: Type: STRINGARRAY [ CHECK-NEXT: Type: STRINGARRAY [
▲ Show 20 Lines • Show All 295 Lines • Show Last 20 Lines

llvm/test/tools/llvm-cvtres/object.test

// Check COFF emission of cvtres // Check COFF emission of cvtres
// The input was generated with the following command, using the original Windows // The input was generated with the following command, using the original Windows
// rc.exe: // rc.exe:
// > rc /fo test_resource.res /nologo test_resource.rc // > rc /fo test_resource.res /nologo test_resource.rc
// The object file we are comparing against was generated with this command using // The object file we are comparing against was generated with this command using
// the original Windows cvtres.exe. // the original Windows cvtres.exe.
// > cvtres /machine:X86 /readonly /nologo /out:test_resource.obj.coff \ // > cvtres /machine:X86 /readonly /nologo /out:test_resource.obj.coff \
// test_resource.res // test_resource.res
// FIXME: This test doesn't work on powerpc64 BE. Re-enable it once it
// is fixed. See pr33429.
UNSUPPORTED: powerpc64-unknown-linux-gnu
RUN: llvm-cvtres /verbose /out:%t %p/Inputs/test_resource.res RUN: llvm-cvtres /verbose /out:%t %p/Inputs/test_resource.res
RUN: llvm-readobj -coff-resources -section-data %t | FileCheck %s RUN: llvm-readobj -coff-resources -section-data %t | FileCheck %s
CHECK: Resources [ CHECK: Resources [
CHECK-NEXT: Total Number of Resources: 8 CHECK-NEXT: Total Number of Resources: 8
CHECK-DAG: Number of String Entries: 1 CHECK-DAG: Number of String Entries: 1
CHECK-NEXT: Number of ID Entries: 4 CHECK-NEXT: Number of ID Entries: 4
CHECK-NEXT: Type: STRINGARRAY [ CHECK-NEXT: Type: STRINGARRAY [
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines