This is an archive of the discontinued LLVM Phabricator instance.

Differential D34171

Use reference to iterate through string table instead of copying.
ClosedPublic

Authored by ecbeckmann on Jun 13 2017, 2:04 PM.

Details

Reviewers
None
Commits
rG0096d78bf978: Use reference to iterate through string table instead of copying.
rL305324: Use reference to iterate through string table instead of copying.
Summary

just a quick patch

Diff Detail

Event Timeline

ecbeckmann created this revision.Jun 13 2017, 2:04 PM
Herald added a subscriber: hiraditya. · View Herald TranscriptJun 13 2017, 2:04 PM
Closed by commit rL305324: Use reference to iterate through string table instead of copying. (authored by ecbeckmann). · Explain WhyJun 13 2017, 2:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
Object/
2 lines

Diff 102405

llvm/lib/Object/WindowsResource.cpp

Show First 20 Lines • Show All 684 Lines • ▼ Show 20 Lines for (auto DataNodes : DataEntriesTreeOrder) {
CurrentOffset += sizeof(llvm::object::coff_resource_data_entry); CurrentOffset += sizeof(llvm::object::coff_resource_data_entry);
CurrentRelativeOffset += sizeof(llvm::object::coff_resource_data_entry); CurrentRelativeOffset += sizeof(llvm::object::coff_resource_data_entry);
} }
} }
void WindowsResourceCOFFWriter::writeDirectoryStringTable() { void WindowsResourceCOFFWriter::writeDirectoryStringTable() {
// Now write the directory string table for .rsrc$01 // Now write the directory string table for .rsrc$01
uint32_t TotalStringTableSize = 0; uint32_t TotalStringTableSize = 0;
for (auto String : StringTable) { for (auto &String : StringTable) {
uint16_t Length = String.size(); uint16_t Length = String.size();
support::endian::write16le(BufferStart + CurrentOffset, Length); support::endian::write16le(BufferStart + CurrentOffset, Length);
CurrentOffset += sizeof(uint16_t); CurrentOffset += sizeof(uint16_t);
auto *Start = reinterpret_cast<UTF16 *>(BufferStart + CurrentOffset); auto *Start = reinterpret_cast<UTF16 *>(BufferStart + CurrentOffset);
std::copy(String.begin(), String.end(), Start); std::copy(String.begin(), String.end(), Start);
CurrentOffset += Length * sizeof(UTF16); CurrentOffset += Length * sizeof(UTF16);
TotalStringTableSize += Length * sizeof(UTF16) + sizeof(uint16_t); TotalStringTableSize += Length * sizeof(UTF16) + sizeof(uint16_t);
} }
▲ Show 20 Lines • Show All 43 Lines • Show Last 20 Lines