Page MenuHomePhabricator

[OpenCL] Diagnose scoped address-space qualified variables
ClosedPublic

Authored by svenvh on Jun 8 2017, 2:34 AM.

Details

Summary

Variables qualified with the local or const address space may only be
declared in the outermost scope of a kernel.

Patch by Simon Perretta.

Diff Detail

Repository
rL LLVM

Event Timeline

svenvh created this revision.Jun 8 2017, 2:34 AM
Anastasia accepted this revision.Jun 19 2017, 10:16 AM

LGTM! Small comment in the test can be addressed in commit!

test/SemaOpenCL/storageclass.cl
52 ↗(On Diff #101872)

I would just move this into foo as it tests similar functionality already.

This revision is now accepted and ready to land.Jun 19 2017, 10:16 AM
This revision was automatically updated to reflect the committed changes.