Page MenuHomePhabricator

Make the parser close parens for you on EOF
AbandonedPublic

Authored by fowles on May 27 2017, 12:20 PM.

Details

Reviewers
sbenza
Summary

Makes the parser for clang-query auto close all open parens on EOF

Event Timeline

fowles created this revision.May 27 2017, 12:20 PM
alexfh edited reviewers, added: sbenza; removed: alexfh.May 30 2017, 2:26 AM
alexfh added a subscriber: alexfh.

Sam knows this stuff much better.

sbenza edited edge metadata.May 30 2017, 6:57 AM

Do we want this change in the parser itself? or in clang-query?
clang-query could be helpful enough to add parens when it detect an ET_ParserNoCloseParen error, without changing the language here.

fowles abandoned this revision.May 30 2017, 8:30 AM

Switching to https://reviews.llvm.org/D33679 for sbenza's suggestion