This is an archive of the discontinued LLVM Phabricator instance.

[coroutines] Allow rematerialization upto 4 times. Remove incorrect assert
ClosedPublic

Authored by GorNishanov on May 24 2017, 3:41 PM.

Diff Detail

Event Timeline

GorNishanov created this revision.May 24 2017, 3:41 PM
GorNishanov accepted this revision.May 24 2017, 3:49 PM

Simple change. LGTM

This revision is now accepted and ready to land.May 24 2017, 3:49 PM
majnemer requested changes to this revision.May 24 2017, 3:54 PM
majnemer added inline comments.
lib/Transforms/Coroutines/CoroFrame.cpp
817

Please abide by the coding convention.

This revision now requires changes to proceed.May 24 2017, 3:54 PM
This revision was automatically updated to reflect the committed changes.
GorNishanov added inline comments.May 24 2017, 5:51 PM
lib/Transforms/Coroutines/CoroFrame.cpp
817

I will be glad to. Can you clarify what coding convention you are referring to?

GorNishanov added inline comments.May 24 2017, 5:58 PM
lib/Transforms/Coroutines/CoroFrame.cpp
817

Got it. Sanjoy clarified that variables start with Capital letters.

Fixed in r303826 = bd45455a1b871466ff8775882ea18f20bbf3a990