This is an archive of the discontinued LLVM Phabricator instance.

Fix bad change in RenderScriptx86ABIFixups.cpp, forgot to change everything necessary
ClosedPublic

Authored by xiaobai on May 23 2017, 12:19 PM.

Reviewers

Commits

Summary

I didn't change all instances of i to I in this loop. I am a bad person and should feel bad. :(

Build Status

Buildable 6696
Build 6696: arc lint + arc unit

This revision was automatically updated to reflect the committed changes.

Path

Size

source/

Plugins/

LanguageRuntime/

RenderScript/

RenderScriptRuntime/

4 lines

Show First 20 Lines • Show All 251 Lines • ▼ Show 20 Lines	for (auto call_inst : rs_callsites) {

// get the function attributes		// get the function attributes
llvm::AttributeList call_attribs = call_inst->getAttributes();		llvm::AttributeList call_attribs = call_inst->getAttributes();

// iterate over the argument attributes		// iterate over the argument attributes
for (unsigned I = call_attribs.index_begin(); I != call_attribs.index_end();		for (unsigned I = call_attribs.index_begin(); I != call_attribs.index_end();
I++) {		I++) {
// if this argument is passed by val		// if this argument is passed by val
if (call_attribs.hasAttribute(i, llvm::Attribute::ByVal)) {		if (call_attribs.hasAttribute(I, llvm::Attribute::ByVal)) {
// strip away the byval attribute		// strip away the byval attribute
call_inst->removeAttribute(i, llvm::Attribute::ByVal);		call_inst->removeAttribute(I, llvm::Attribute::ByVal);
changed = true;		changed = true;
}		}
}		}
}		}

// for all called function decls		// for all called function decls
for (auto func : rs_functions) {		for (auto func : rs_functions) {
// inspect all of the arguments in the call		// inspect all of the arguments in the call
Show All 27 Lines