Decrease inlinecold-threshold to 45
ClosedPublic

Authored by eraman on May 11 2017, 11:59 AM.

Details

Summary

I ran the test-suite (including SPEC 2006) in PGO mode comparing cold thresholds of 225 and 45. Here are some stats on the text size:

Out of 904 tests that ran, 197 see a change in text size. The average text size reduction (of all the 904 binaries) is 1.07%. Of the 197 binaries, 19 see a text size increase, as high as 18%, but most of them are small single source benchmarks. There are 3 multisource benchmarks with a >0.5% size increase (0.7, 1.3 and 2.1 are their % increases). On the other side of the spectrum, 31 benchmarks see >10% size reduction and 6 of them are MultiSource.

I haven't run the test-suite with other values of inlinecold-threshold. Since we have a cold callsite threshold of 45, I picked this value.

Diff Detail

Repository
rL LLVM
eraman created this revision.May 11 2017, 11:59 AM
chandlerc accepted this revision.May 11 2017, 12:03 PM

This seems like a strict improvement to me. I'd love to have a more thorough analysis of different values here but I don't see any reason to hold up bringing this in line with the cold callsite threshold. LGTM.

This revision is now accepted and ready to land.May 11 2017, 12:03 PM
This revision was automatically updated to reflect the committed changes.