[inline asm] dot operator while using imm generates wrong ir + asm

[• zizhar]

Summary

a fix to https://bugs.llvm.org//show_bug.cgi?id=32987

test review link: https://reviews.llvm.org/D33040

[ahatanak]

This looks correct.

[rnk]

Looks good.

I would recommend using the github monorepo to send and submit patches that cross clang and LLVM: http://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-a-git-monorepo It should make it easier to review and submit these kinds of changes.

In the glorious future, if you are serious about improving the ms/Intel inline asm parser, we should come up with a test frontend so that we can move most of these tests back into LLVM. Until that day, I recommend the monorepo. :)

llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp

if (SemaCallback->LookupInlineAsmField(BaseMember.first, BaseMember.second,
       return Error(Tok.getLoc(), "Unable to lookup field reference!");
     DotDispVal = DotDisp;
   } else
     return Error(Tok.getLoc(), "Unexpected token type!");
 
   if (isParsingInlineAsm() && Tok.is(AsmToken::Identifier)) {
     SMLoc Loc = SMLoc::getFromPointer(DotDispStr.data());
     unsigned Len = DotDispStr.size();
-    unsigned Val = OrigDispVal + DotDispVal;
-    InstInfo->AsmRewrites->emplace_back(AOK_DotOperator, Loc, Len, Val);
+    InstInfo->AsmRewrites->emplace_back(AOK_DotOperator, Loc, Len, DotDispVal);
   }
 
   NewDisp = MCConstantExpr::create(OrigDispVal + DotDispVal, getContext());
   return false;
 }
 
 /// Parse the 'offset' operator.  This operator is used to specify the
 /// location rather then the content of a variable.