This is an archive of the discontinued LLVM Phabricator instance.

[Triple] Add a "macos" OS type that acts as a synonym for "macosx"
ClosedPublic

Authored by arphaman on May 2 2017, 7:14 AM.

Details

Summary

The "macosx" OS type is still the canonical type. In the future "macos" will become the canonical OS type (but we will still support "macosx").

Diff Detail

Repository
rL LLVM

Event Timeline

arphaman created this revision.May 2 2017, 7:14 AM
majnemer added inline comments.
lib/Support/Triple.cpp
987–988 ↗(On Diff #97444)

You could simplify this:

else if (getOS() == MacOSX)
  OSName.consume_front("macos");
chandlerc accepted this revision.May 2 2017, 10:35 PM

LGTM with David's suggested change.

This revision is now accepted and ready to land.May 2 2017, 10:35 PM
This revision was automatically updated to reflect the committed changes.
arphaman marked an inline comment as done.