This is an archive of the discontinued LLVM Phabricator instance.

Differential D32359

[tsan] Track external API accesses as 1-byte accesses (instead of 8-byte)
ClosedPublic

Authored by kubamracek on Apr 21 2017, 10:24 AM.

Details

Reviewers
dvyukov
Commits
rG676d008198f7: [tsan] Track external API accesses as 1-byte accesses (instead of 8-byte)
rCRT301001: [tsan] Track external API accesses as 1-byte accesses (instead of 8-byte)
rL301001: [tsan] Track external API accesses as 1-byte accesses (instead of 8-byte)
Summary

It doesn't really make sense to track them as 8-byte accesses.

Diff Detail

Repository
rL LLVM

Event Timeline

kubamracek created this revision.Apr 21 2017, 10:24 AM
dvyukov accepted this revision.Apr 21 2017, 10:30 AM
This revision is now accepted and ready to land.Apr 21 2017, 10:30 AM
Closed by commit rL301001: [tsan] Track external API accesses as 1-byte accesses (instead of 8-byte) (authored by kuba.brecka). · Explain WhyApr 21 2017, 10:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
lib/
tsan/
rtl/
4 lines

Diff 96173

compiler-rt/trunk/lib/tsan/rtl/tsan_external.cc

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines
SANITIZER_INTERFACE_ATTRIBUTE SANITIZER_INTERFACE_ATTRIBUTE
void __tsan_external_read(void *addr, void *caller_pc, void *tag) { void __tsan_external_read(void *addr, void *caller_pc, void *tag) {
CHECK_LT(tag, atomic_load(&used_tags, memory_order_relaxed)); CHECK_LT(tag, atomic_load(&used_tags, memory_order_relaxed));
ThreadState *thr = cur_thread(); ThreadState *thr = cur_thread();
thr->external_tag = (uptr)tag; thr->external_tag = (uptr)tag;
if (caller_pc) FuncEntry(thr, (uptr)caller_pc); if (caller_pc) FuncEntry(thr, (uptr)caller_pc);
bool in_ignored_lib; bool in_ignored_lib;
if (!caller_pc || !libignore()->IsIgnored((uptr)caller_pc, &in_ignored_lib)) { if (!caller_pc || !libignore()->IsIgnored((uptr)caller_pc, &in_ignored_lib)) {
MemoryRead(thr, CALLERPC, (uptr)addr, kSizeLog8); MemoryRead(thr, CALLERPC, (uptr)addr, kSizeLog1);
} }
if (caller_pc) FuncExit(thr); if (caller_pc) FuncExit(thr);
thr->external_tag = 0; thr->external_tag = 0;
} }
SANITIZER_INTERFACE_ATTRIBUTE SANITIZER_INTERFACE_ATTRIBUTE
void __tsan_external_write(void *addr, void *caller_pc, void *tag) { void __tsan_external_write(void *addr, void *caller_pc, void *tag) {
CHECK_LT(tag, atomic_load(&used_tags, memory_order_relaxed)); CHECK_LT(tag, atomic_load(&used_tags, memory_order_relaxed));
ThreadState *thr = cur_thread(); ThreadState *thr = cur_thread();
thr->external_tag = (uptr)tag; thr->external_tag = (uptr)tag;
if (caller_pc) FuncEntry(thr, (uptr)caller_pc); if (caller_pc) FuncEntry(thr, (uptr)caller_pc);
bool in_ignored_lib; bool in_ignored_lib;
if (!caller_pc || !libignore()->IsIgnored((uptr)caller_pc, &in_ignored_lib)) { if (!caller_pc || !libignore()->IsIgnored((uptr)caller_pc, &in_ignored_lib)) {
MemoryWrite(thr, CALLERPC, (uptr)addr, kSizeLog8); MemoryWrite(thr, CALLERPC, (uptr)addr, kSizeLog1);
} }
if (caller_pc) FuncExit(thr); if (caller_pc) FuncExit(thr);
thr->external_tag = 0; thr->external_tag = 0;
} }
} // extern "C" } // extern "C"
} // namespace __tsan } // namespace __tsan