Page MenuHomePhabricator

Add more arguments to SocketAddress::GetAddressInfo
ClosedPublic

Authored by labath on Apr 21 2017, 9:41 AM.

Details

Summary

the reason for this is two-fold:

  • getaddrinfo without the extra arguments will return the same

(network-level) address multiple times, once for each supported
transport protocol, which is not what is usually intended (it certainly
wasn't in D31823)

  • it enables us to rewrite the getaddrinfo member function in terms of

the static GetAddressInfo function.

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.Apr 21 2017, 9:41 AM
beanz accepted this revision.Apr 21 2017, 2:06 PM

This is awesome! Thanks!

This revision is now accepted and ready to land.Apr 21 2017, 2:06 PM
This revision was automatically updated to reflect the committed changes.