This is an archive of the discontinued LLVM Phabricator instance.

Documentation update for a shorter libfuzzer flag in D32193
ClosedPublic

Authored by george.karpenkov on Apr 19 2017, 4:52 PM.

Details

Reviewers
kcc
Summary

Updates documentation for a syntax sugar libfuzzer flag, as implemented in https://reviews.llvm.org/D32193

Diff Detail

Event Timeline

kcc edited edge metadata.Apr 19 2017, 5:06 PM

Mmm... No. I still want to have documentation that includes building libFuzzer manually.
I'd rather insert a paragraph explaining how to use -fsanitize=fuzzer with a fresh clang install, but leave the rest unchanged.

Sure. Wouldn't it make more sense to move it down into "Developing libfuzzer"?
A user can only compile libfuzzer using Clang anyway (due to coverage), and Clang has to be new (as coverage flags change from my understanding).
Thus using "-fsanitize=fuzzer" seems a more sensible default instruction, then compiling libfuzzer and adding coverage instructions manually.

kcc added a comment.Apr 19 2017, 5:18 PM

you don't need fresh clang to build libFuzzer itself.
besides, there is already *some* support for using libFuzzer with gcc.

How about this: you start this section from "if you have a very recent (> April 20 2017) build of clang, use -fsanitize=fuzzer (example)"

then the rest of the existing text follows

kcc accepted this revision.Apr 19 2017, 5:29 PM

LGTM
Sounds good, but I suggest to wait with this change until we fix all the build failures that were caused by enabling libFuzzer build by default.

This revision is now accepted and ready to land.Apr 19 2017, 5:29 PM