This is an archive of the discontinued LLVM Phabricator instance.

CodeGen: Let byval parameter use alloca address space
ClosedPublic

Authored by yaxunl on Apr 17 2017, 12:32 PM.

Reviewers

Commits

LGTM.

This revision is now accepted and ready to land.Apr 17 2017, 1:02 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

CodeGen/

5 lines

test/

CodeGenOpenCL/

18 lines

	Show First 20 Lines • Show All 992 Lines • ▼ Show 20 Lines
	switch (ArgInfo.getKind()) {			switch (ArgInfo.getKind()) {
	case ABIArgInfo::Ignore:			case ABIArgInfo::Ignore:
	case ABIArgInfo::InAlloca:			case ABIArgInfo::InAlloca:
	assert(NumIRArgs == 0);			assert(NumIRArgs == 0);
	break;			break;

	case ABIArgInfo::Indirect: {			case ABIArgInfo::Indirect: {
	assert(NumIRArgs == 1);			assert(NumIRArgs == 1);
	// indirect arguments are always on the stack, which is addr space #0.			// indirect arguments are always on the stack, which is alloca addr space.
	llvm::Type *LTy = ConvertTypeForMem(it->type);			llvm::Type *LTy = ConvertTypeForMem(it->type);
	ArgTypes[FirstIRArg] = LTy->getPointerTo();			ArgTypes[FirstIRArg] = LTy->getPointerTo(
				CGM.getDataLayout().getAllocaAddrSpace());
	break;			break;
	}			}

	case ABIArgInfo::Extend:			case ABIArgInfo::Extend:
	case ABIArgInfo::Direct: {			case ABIArgInfo::Direct: {
	// Fast-isel and the optimizer generally like scalar values better than			// Fast-isel and the optimizer generally like scalar values better than
	// FCAs, so we flatten them if this is safe to do for this argument.			// FCAs, so we flatten them if this is safe to do for this argument.
	llvm::Type *argType = ArgInfo.getCoerceToType();			llvm::Type *argType = ArgInfo.getCoerceToType();
	▲ Show 20 Lines • Show All 992 Lines • Show Last 20 Lines

				// RUN: %clang_cc1 -emit-llvm -o - -triple amdgcn %s \| FileCheck %s
				// RUN: %clang_cc1 -emit-llvm -o - -triple amdgcn---amdgizcl %s \| FileCheck %s -check-prefix=AMDGIZ

				struct A {
				int x[100];
				};

				int f(struct A a);

				int g() {
				struct A a;
				// CHECK: call i32 @f(%struct.A* byval{{.*}}%a)
				// AMDGIZ: call i32 @f(%struct.A addrspace(5)* byval{{.*}}%a)
				return f(a);
				}

				// CHECK: declare i32 @f(%struct.A* byval{{.*}})
				// AMDGIZ: declare i32 @f(%struct.A addrspace(5)* byval{{.*}})