This is an archive of the discontinued LLVM Phabricator instance.

unnecessary condition fixes
ClosedPublic

Authored by • SilverGeri on Apr 11 2017, 8:29 AM.

Reviewers

klimek
xazax.hun

Commits

Summary

fix based on readability-delete-null-pointer

LGTM!

This revision is now accepted and ready to land.Apr 19 2017, 8:18 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

cfe/

trunk/

lib/

AST/

6 lines

Show First 20 Lines • Show All 9,408 Lines • ▼ Show 20 Lines	bool TraverseNode(T Node, MapNodeTy MapNode,
NodeOrVector = S;		NodeOrVector = S;
else		else
NodeOrVector =		NodeOrVector =
new ast_type_traits::DynTypedNode(ParentStack.back());		new ast_type_traits::DynTypedNode(ParentStack.back());
} else {		} else {
if (!NodeOrVector.template is<ASTContext::ParentVector *>()) {		if (!NodeOrVector.template is<ASTContext::ParentVector *>()) {
auto *Vector = new ASTContext::ParentVector(		auto *Vector = new ASTContext::ParentVector(
1, getSingleDynTypedNodeFromParentMap(NodeOrVector));		1, getSingleDynTypedNodeFromParentMap(NodeOrVector));
if (auto *Node =		delete NodeOrVector
NodeOrVector		.template dyn_cast<ast_type_traits::DynTypedNode *>();
.template dyn_cast<ast_type_traits::DynTypedNode *>())
delete Node;
NodeOrVector = Vector;		NodeOrVector = Vector;
}		}

auto *Vector =		auto *Vector =
NodeOrVector.template get<ASTContext::ParentVector *>();		NodeOrVector.template get<ASTContext::ParentVector *>();
// Skip duplicates for types that have memoization data.		// Skip duplicates for types that have memoization data.
// We must check that the type has memoization data before calling		// We must check that the type has memoization data before calling
// std::find() because DynTypedNode::operator== can't compare all		// std::find() because DynTypedNode::operator== can't compare all
▲ Show 20 Lines • Show All 139 Lines • Show Last 20 Lines