Page MenuHomePhabricator
Differential D31590

[coroutines] Add support for deallocation elision
ClosedPublic
Actions

Authored by GorNishanov on Apr 2 2017, 8:34 PM.

Details

Reviewers
majnemer
EricWF
GorNishanov
Summary

Wrap deallocation code with:

if (auto *mem = coro.free()) Deallocate

When backend decides to elide allocations it will replace coro.free with nullptr to suppress deallocation code.

Diff Detail

Event Timeline

GorNishanov created this revision.Apr 2 2017, 8:34 PM
GorNishanov awarded a token.
GorNishanov added a parent revision: D31586: [coroutines] Replace all coro.frame builtins with an SSA value of coro.begin.
GorNishanov added a child revision: D31608: [coroutines] Add emission of initial and final suspends.Apr 3 2017, 10:38 AM
GorNishanov added a comment.Apr 10 2017, 2:08 PM

Gentle ping

GorNishanov accepted this revision.May 22 2017, 9:17 PM

LGTM

GorNishanov added a comment.May 22 2017, 9:26 PM

Commited: r303599 = abbd4f85db96b0ed1478e2ee52e9f1eec7404131

GorNishanov removed 1 blocking reviewer(s): majnemer.May 22 2017, 9:46 PM
This revision is now accepted and ready to land.May 22 2017, 9:46 PM
GorNishanov closed this revision.May 22 2017, 9:47 PM

Revision Contents
Changeset List

PathSize
lib/
CodeGen/
58 lines
test/
CodeGenCoroutines/
8 lines

Diff 93822

View Options

lib/CodeGen/CGCoroutine.cpp

Loading...
View Options

test/CodeGenCoroutines/coro-alloc.cpp

Loading...