This is an archive of the discontinued LLVM Phabricator instance.

Add LIT_USE_INTERNAL_SHELL to compiler-rt tests

Authored by rafael on Mar 28 2017, 8:50 AM.



I am working on improving our internal bot infrastructure. One thing that is unique to the ps4 is that we want to run the posix tests, but have to execute them on windows.

We currently have a local hack to use a shell on windows, but it is pretty much impossible to get all all the tools to play nice with all the heuristics for what is a path and what is a command line option.

This adds support LIT_USE_INTERNAL_SHELL and I will then try to fix the tests that fail with it but adding the missing features.

Is there a way to share this code with llvm? clang also has it duplicated.

Diff Detail

Event Timeline

rafael created this revision.Mar 28 2017, 8:50 AM
filcab accepted this revision.Mar 30 2017, 6:32 AM

LGTM as it's reproducing behavior from the other test suites in llvm.

This revision is now accepted and ready to land.Mar 30 2017, 6:32 AM
rafael closed this revision.Mar 30 2017, 6:46 AM