[COFF] Put the PDB next to the image if the user doesn't pass /PDB:

[rnk]

Summary

This is compatible with MSVC link.exe.

[ruiu]

LGTM

COFF/Driver.cpp

896 ↗

(On Diff #92573)

Remove llvm::.

[rnk]

This broke a CFI stats test, which I XFAILd in a follow up:
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/8407

This makes LLD produce PDBs when it is just passed /debug and nothing else, and our PDBs are obviously incorrect. Is that OK?

lld/trunk/COFF/Config.h

struct Configuration {
   bool DoGC = true;
   bool DoICF = true;
   uint64_t ErrorLimit = 20;
   bool Relocatable = true;
   bool Force = false;
   bool Debug = false;
   bool WriteSymtab = true;
   unsigned DebugTypes = static_cast<unsigned>(DebugType::None);
-  StringRef PDBPath;
+  llvm::SmallString<128> PDBPath;
 
   // Symbols in this set are considered as live by the garbage collector.
   std::set<SymbolBody *> GCRoot;
 
   std::set<StringRef> NoDefaultLibs;
   bool NoDefaultLibAll = false;
 
   // True if we are creating a DLL.

lld/trunk/COFF/Driver.cpp

void LinkerDriver::link(ArrayRef<const char *> ArgsArr) {
   }
 
   // Set default image name if neither /out or /def set it.
   if (Config->OutputFile.empty()) {
     Config->OutputFile =
         getOutputPath((*Args.filtered_begin(OPT_INPUT))->getValue());
   }
 
+  // Put the PDB next to the image if no /pdb flag was passed.
+  if (Config->Debug && Config->PDBPath.empty()) {
+    Config->PDBPath = Config->OutputFile;
+    sys::path::replace_extension(Config->PDBPath, ".pdb");
+  }
+
   // Set default image base if /base is not given.
   if (Config->ImageBase == uint64_t(-1))
     Config->ImageBase = getDefaultImageBase();
 
   Symtab.addRelative(mangle("__ImageBase"), 0);
   if (Config->Machine == I386) {
     Config->SEHTable = Symtab.addRelative("___safe_se_handler_table", 0);
     Config->SEHCount = Symtab.addAbsolute("___safe_se_handler_count", 0);

lld/trunk/test/COFF/rsds.test

 # RUN: yaml2obj %s > %t.obj
 
 # RUN: lld-link /debug /dll /out:%t.dll /entry:DllMain %t.obj
 # RUN: llvm-readobj -coff-debug-directory %t.dll | FileCheck %s
 
 # RUN: lld-link /debug /pdb:%t.pdb /dll /out:%t.dll /entry:DllMain %t.obj
-# RUN: llvm-readobj -coff-debug-directory %t.dll | FileCheck %s -check-prefix CHECK-PDB
+# RUN: llvm-readobj -coff-debug-directory %t.dll | FileCheck %s
 
 # CHECK: DebugDirectory [
 # CHECK:   DebugEntry {
 # CHECK:     Characteristics: 0x0
 # CHECK:     TimeDateStamp: 1970-01-01 00:00:00 (0x0)
 # CHECK:     MajorVersion: 0x0
 # CHECK:     MinorVersion: 0x0
 # CHECK:     Type: CodeView (0x2)
-# CHECK:     SizeOfData: 0x19
+# CHECK:     SizeOfData:
 # CHECK:     AddressOfRawData:
 # CHECK:     PointerToRawData:
 # CHECK:     PDBInfo {
 # CHECK:       PDBSignature: 0x53445352
 # CHECK:       PDBGUID:
 # CHECK:       PDBAge: 1
-# CHECK:       PDBFileName: {{$}}
+# CHECK:       PDBFileName: {{.*}}.pdb
 # CHECK:     }
 # CHECK:   }
 # CHECK: ]
 
-# CHECK-PDB: DebugDirectory [
-# CHECK-PDB:   DebugEntry {
-# CHECK-PDB:     Characteristics: 0x0
-# CHECK-PDB:     TimeDateStamp: 1970-01-01 00:00:00 (0x0)
-# CHECK-PDB:     MajorVersion: 0x0
-# CHECK-PDB:     MinorVersion: 0x0
-# CHECK-PDB:     Type: CodeView (0x2)
-# CHECK-PDB:     SizeOfData:
-# CHECK-PDB:     AddressOfRawData:
-# CHECK-PDB:     PointerToRawData:
-# CHECK-PDB:     PDBInfo {
-# CHECK-PDB:       PDBSignature: 0x53445352
-# CHECK-PDB:       PDBGUID:
-# CHECK-PDB:       PDBAge: 1
-# CHECK-PDB:       PDBFileName: {{.*}}.pdb
-# CHECK-PDB:     }
-# CHECK-PDB:   }
-# CHECK-PDB: ]
-
 --- !COFF
 header:
   Machine:         IMAGE_FILE_MACHINE_I386
   Characteristics: [  ]
 sections:
   - Name:            .text
     Characteristics: [ IMAGE_SCN_CNT_CODE, IMAGE_SCN_MEM_EXECUTE, IMAGE_SCN_MEM_READ ]
     Alignment:       4