Page MenuHomePhabricator

Object/COFF: add function to check if section number is reserved one
ClosedPublic

Authored by ruiu on Mar 17 2014, 4:22 PM.

Details

Summary

Looks like there's no pass to run the pieces of code in COFFObjectFile.cpp
that I modified. Are these dead code? I changed the code but can't write test
for it.

Diff Detail

Event Timeline

Bigcheese accepted this revision.Mar 18 2014, 12:20 AM

It was probably just never tested.

ruiu updated this revision to Unknown Object (????).Mar 18 2014, 12:38 PM
  • added tests
ruiu added a comment.Mar 18 2014, 12:42 PM

OK I figured out the test that uses getSection on a COFF file. Added a new test for it.

ruiu closed this revision.Mar 18 2014, 4:45 PM

Closed by commit rL204199 (authored by @ruiu).