This is an archive of the discontinued LLVM Phabricator instance.

Add documentation on debug counters to Programmers Manual.
ClosedPublic

Authored by dberlin on Mar 10 2017, 12:58 PM.

Event Timeline

dberlin created this revision.Mar 10 2017, 12:58 PM
This revision was automatically updated to reflect the committed changes.

Ugh, that was an accident.
Still want to hear anything folks have to say about this.

mehdi_amini edited edge metadata.Mar 11 2017, 9:06 PM

LGTM, but see a few inline comments.

llvm/trunk/docs/ProgrammersManual.rst
1215 ↗(On Diff #91489)

Somehow I feel the word bisect should be present in this description, that may help the reader to "connect" quickly to the use case.

1233 ↗(On Diff #91489)

I don't know why this block is indented (I don't write rst every day either). If it is intentional then fine :)

1265 ↗(On Diff #91489)

The line returns seem a bit funky? (80 cols)

dberlin marked 3 inline comments as done.Mar 13 2017, 12:18 PM
dberlin added inline comments.
llvm/trunk/docs/ProgrammersManual.rst
1233 ↗(On Diff #91489)

I copied the style from what we did in statistics above, but looking at the output of that and this, it's clearly wrong.
i'll fix both.