This is an archive of the discontinued LLVM Phabricator instance.

[OpenCL] Fix extension guards for atomic functions
ClosedPublic

Authored by jprice on Mar 10 2017, 8:10 AM.

Download Raw Diff

Details

Reviewers

yaxunl
Anastasia

Diff Detail

Build Status

Buildable 4688
Build 4688: arc lint + arc unit

Event Timeline

jprice created this revision.Mar 10 2017, 8:10 AM

LGTM! This bit was poorly tested initially as there were simply too many things. I am wondering if we could improve these bits slowly by extending further lib/Headers/opencl-c.h.

This revision is now accepted and ready to land.Mar 10 2017, 8:17 AM

Thanks - could you commit this on my behalf please?

Ping - maybe this got lost in the noise.

I don't have commit access - could somebody commit this on my behalf please?

Diffusion mentioned this in rL298256: [OpenCL] Fix extension guards for atomic functions.Mar 20 2017, 8:15 AM

Sorry, I overlooked this indeed. Committed in r298256!

Revision Contents

Path

Size

lib/

Headers/

opencl-c.h

6 lines

Diff 91346

lib/Headers/opencl-c.h

This file is larger than 256 KB, so syntax highlighting is disabled by default.

	Show First 20 Lines • Show All 14,389 Lines • ▼ Show 20 Lines
	unsigned int __ovld atomic_xchg(volatile __global unsigned int *p, unsigned int val);			unsigned int __ovld atomic_xchg(volatile __global unsigned int *p, unsigned int val);
	int __ovld atomic_xchg(volatile __local int *p, int val);			int __ovld atomic_xchg(volatile __local int *p, int val);
	unsigned int __ovld atomic_xchg(volatile __local unsigned int *p, unsigned int val);			unsigned int __ovld atomic_xchg(volatile __local unsigned int *p, unsigned int val);
	float __ovld atomic_xchg(volatile __global float *p, float val);			float __ovld atomic_xchg(volatile __global float *p, float val);
	float __ovld atomic_xchg(volatile __local float *p, float val);			float __ovld atomic_xchg(volatile __local float *p, float val);

	#if defined(cl_khr_global_int32_base_atomics)			#if defined(cl_khr_global_int32_base_atomics)
	int __ovld atom_xchg(volatile __global int *p, int val);			int __ovld atom_xchg(volatile __global int *p, int val);
	int __ovld atom_xchg(volatile __local int *p, int val);			unsigned int __ovld atom_xchg(volatile __global unsigned int *p, unsigned int val);
	#endif			#endif
	#if defined(cl_khr_local_int32_base_atomics)			#if defined(cl_khr_local_int32_base_atomics)
	unsigned int __ovld atom_xchg(volatile __global unsigned int *p, unsigned int val);			int __ovld atom_xchg(volatile __local int *p, int val);
	unsigned int __ovld atom_xchg(volatile __local unsigned int *p, unsigned int val);			unsigned int __ovld atom_xchg(volatile __local unsigned int *p, unsigned int val);
	#endif			#endif

	#if defined(cl_khr_int64_base_atomics)			#if defined(cl_khr_int64_base_atomics)
	long __ovld atom_xchg(volatile __global long *p, long val);			long __ovld atom_xchg(volatile __global long *p, long val);
	long __ovld atom_xchg(volatile __local long *p, long val);			long __ovld atom_xchg(volatile __local long *p, long val);
	unsigned long __ovld atom_xchg(volatile __global unsigned long *p, unsigned long val);			unsigned long __ovld atom_xchg(volatile __global unsigned long *p, unsigned long val);
	unsigned long __ovld atom_xchg(volatile __local unsigned long *p, unsigned long val);			unsigned long __ovld atom_xchg(volatile __local unsigned long *p, unsigned long val);
	▲ Show 20 Lines • Show All 100 Lines • ▼ Show 20 Lines
	#if defined(cl_khr_local_int32_extended_atomics)			#if defined(cl_khr_local_int32_extended_atomics)
	int __ovld atom_min(volatile __local int *p, int val);			int __ovld atom_min(volatile __local int *p, int val);
	unsigned int __ovld atom_min(volatile __local unsigned int *p, unsigned int val);			unsigned int __ovld atom_min(volatile __local unsigned int *p, unsigned int val);
	#endif			#endif

	#if defined(cl_khr_int64_extended_atomics)			#if defined(cl_khr_int64_extended_atomics)
	long __ovld atom_min(volatile __global long *p, long val);			long __ovld atom_min(volatile __global long *p, long val);
	unsigned long __ovld atom_min(volatile __global unsigned long *p, unsigned long val);			unsigned long __ovld atom_min(volatile __global unsigned long *p, unsigned long val);
	#endif
	#if defined(cl_khr_local_int32_extended_atomics)
	long __ovld atom_min(volatile __local long *p, long val);			long __ovld atom_min(volatile __local long *p, long val);
	unsigned long __ovld atom_min(volatile __local unsigned long *p, unsigned long val);			unsigned long __ovld atom_min(volatile __local unsigned long *p, unsigned long val);
	#endif			#endif

	/**			/**
	* Read the 32-bit value (referred to as old)			* Read the 32-bit value (referred to as old)
	* stored at location pointed by p. Compute			* stored at location pointed by p. Compute
	* max(old, val) and store maximum value at			* max(old, val) and store maximum value at
	▲ Show 20 Lines • Show All 2,558 Lines • Show Last 20 Lines