This is an archive of the discontinued LLVM Phabricator instance.

Differential D30518

Fix msc-version.c test to handle _MSC_VER=1910
ClosedPublic

Authored by DaveBartolomeo on Mar 1 2017, 4:56 PM.

Details

Reviewers
rnk
Summary

Previously, VC++ has always set _MSC_VER to a four-digit value with the two least significant digits set to zero. Visual Studio 2017, however, sets _MSC_VER=1910, and we expect to update the least significant digit as we release major updates for VS 2017. This patch fixes the msc-version.c test to handle non-zero values in the two least significant digits of _MSC_VER.

Diff Detail

Event Timeline

DaveBartolomeo created this revision.Mar 1 2017, 4:56 PM
rnk accepted this revision.Mar 1 2017, 4:57 PM

lgtm

This revision is now accepted and ready to land.Mar 1 2017, 4:57 PM
DaveBartolomeo closed this revision.Mar 2 2017, 4:22 PM

269843

Revision Contents

PathSize
test/
Driver/
msc-version.c
msc-version.c (revision 296518)
2 lines

Diff 90259

test/Driver/msc-version.c

Context not available.
// CHECK-MS-EXTENSIONS: _MSC_BUILD 1 // CHECK-MS-EXTENSIONS: _MSC_BUILD 1
// CHECK-MS-EXTENSIONS: _MSC_FULL_VER {{.+}} // CHECK-MS-EXTENSIONS: _MSC_FULL_VER {{.+}}
// CHECK-MS-EXTENSIONS: _MSC_VER {{..}}00 // CHECK-MS-EXTENSIONS: _MSC_VER {{....}}
Context not available.