This is an archive of the discontinued LLVM Phabricator instance.

Fix TestNameLookup for GCC
ClosedPublic

Authored by labath on Feb 14 2017, 4:32 AM.

Details

Summary

GCC emits also symbols for the PRETTY_FUNCTION virtual variable,
which we accidentaly pick up when looking for functions for with
"unique_function_name" in the name. This makes the target.FindFunctions
call fail, as that symbol is not a function.

I also strenghten the test a bit to make sure we actually find all the
functions we are interested in. I've put a check that we find at least 6
functions, but maybe this should be *exactly* 6 ?

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.Feb 14 2017, 4:32 AM
clayborg accepted this revision.Feb 14 2017, 9:12 AM
This revision is now accepted and ready to land.Feb 14 2017, 9:12 AM
This revision was automatically updated to reflect the committed changes.